Relate quote to orders #1866
Draft
Relate quote to orders #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanobash
previously approved these changes
Apr 10, 2024
justnero
reviewed
Apr 10, 2024
Co-authored-by: Arif Kurkchi <[email protected]>
nanobash
previously approved these changes
Apr 11, 2024
i-yasko
previously approved these changes
Apr 11, 2024
|
Another idea is to add |
Alisa007
previously approved these changes
Apr 17, 2024
olasunkanmi04
previously approved these changes
Apr 17, 2024
giokaxo
previously approved these changes
Apr 17, 2024
…ions into use-order-for-quotes
lexerom
dismissed stale reviews from giokaxo, olasunkanmi04, Alisa007, i-yasko, and nanobash
via
719d314
adamaltman
reviewed
Apr 25, 2024
Comment on lines
109
to
115
| _embedded: | ||
| type: object | ||
| description: Embedded objects that are requested by the `expand` query parameter. | ||
| readOnly: true | ||
| properties: | ||
| product: | ||
| type: object |
There was a problem hiding this comment.
Why is this here? There is not even a _links.
There was a problem hiding this comment.
I think initially it was taken from SubscriptionOrOneTimeSaleItem.yaml
ashkarpetin
reviewed
Apr 25, 2024
| required: | ||
| - plan | ||
| properties: | ||
| quoteItemId: |
There was a problem hiding this comment.
Shouldn't id relate to quote item, and orderItemId relate to order item instead?
There was a problem hiding this comment.
The idea is to eventually replace QuoteOrderItem with OrderSubscription.yaml and OrderOneTimeSaleItem.yaml. But yeah, not 100% sure here, it was id for quote item initially.
nanobash
reviewed
Apr 25, 2024
Co-authored-by: Tornike Nanobashvili <[email protected]>
vykhrystiuk
reviewed
Apr 28, 2024
creocoder
previously approved these changes
May 8, 2024
creocoder
previously approved these changes
May 9, 2024
nanobash
reviewed
May 10, 2024
openapi/components/schemas/StorefrontQuoteTrialConversionOrder.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Tornike Nanobashvili <[email protected]>
nanobash
previously approved these changes
May 13, 2024
noon-dawg
approved these changes
May 14, 2024
nanobash
approved these changes
May 14, 2024
creocoder
approved these changes
May 14, 2024
justnero
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace subscriptionId with orderId where orderId relates to Orders. Move order related changes to
orderChangesproperty.Preview
Checklist