Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Sharing Agreement commands. +semver: feature #38

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Adds Sharing Agreement commands. +semver: feature #38

merged 2 commits into from
Mar 30, 2020

Conversation

RobFaie
Copy link
Contributor

@RobFaie RobFaie commented Mar 24, 2020

No description provided.

mderriey
mderriey approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@mderriey mderriey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

PwshZendesk.psd1 Outdated Show resolved Hide resolved
functions/New-SharingAgreement.ps1 Outdated Show resolved Hide resolved
functions/New-SharingAgreement.ps1 Outdated Show resolved Hide resolved
functions/Update-SharingAgreement.ps1 Outdated Show resolved Hide resolved
functions/Update-SharingAgreement.ps1 Outdated Show resolved Hide resolved
functions/Update-SharingAgreement.ps1 Outdated Show resolved Hide resolved
functions/Update-SharingAgreement.ps1 Outdated Show resolved Hide resolved
kjacobsen
kjacobsen approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@kjacobsen kjacobsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 quick comment

@RobFaie RobFaie force-pushed the sharing-agreements branch from 2323eb1 to d8f56ab Compare March 29, 2020 11:10
@RobFaie @mderriey
Apply suggestions from code review
3358c38 
Co-Authored-By: Mickaël Derriey <[email protected]>
@RobFaie RobFaie force-pushed the sharing-agreements branch from d8f56ab to 3358c38 Compare March 29, 2020 11:14
@RobFaie
Copy link
Contributor Author

RobFaie commented Mar 30, 2020

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@RobFaie RobFaie merged commit 1721884 into master Mar 30, 2020
@RobFaie RobFaie deleted the sharing-agreements branch March 30, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mderriey mderriey mderriey approved these changes

@kjacobsen kjacobsen kjacobsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RobFaie @kjacobsen @mderriey