Apply suggestions from code review

Co-Authored-By: Mickaël Derriey <[email protected]>

PwshZendesk.psd1

@@ -97,7 +97,6 @@
         'Get-Problem',                         'Get-ZendeskProblem'
         'Get-SearchCount',                     'Get-ZendeskSearchCount'
         'Get-SharingAgreement',                'Get-ZendeskSharingAgreement'
-        'Get-SharingAgreement',                'Get-ZendeskSharingAgreement'
         'Get-SuspendedTicket',                 'Get-ZendeskSuspendedTicket'
         'Get-Tag',                             'Get-ZendeskTag'
         'Get-Ticket',                          'Get-ZendeskTicket'

README.md

@@ -3,7 +3,7 @@
 ![Build Status]
 
 PwshZendesk is a Zendesk Support API client for Powershell.
-PwshZendesk supports Powershell versions 5.0, 5.1, 6, and 7 on all platforms.
+PwshZendesk supports Powershell versions 5.1, 6, and 7 on all platforms.
 
 
 ## Getting Started
@@ -22,7 +22,7 @@ Head to Admin => Channels => API and click the `+` under "Token Access"
 
 ### Installing
 
-PwshZendesk supports Powershell versions 5.0, 5.1, 6, and 7 on all platforms.
+PwshZendesk supports Powershell versions 5.1, 6, and 7 on all platforms.
 
 It is recommended to install PwshZendesk from the [PowerShell Gallery]:
 

functions/New-SharingAgreement.ps1

@@ -4,14 +4,14 @@ function New-SharingAgreement {
     .SYNOPSIS
         Creates a sharing agreement.
     .DESCRIPTION
-        Creatas a sharing agreement. Requires sharing to be enabled on the Zendesk instance. For more information see: https://support.zendesk.com/hc/en-us/articles/203661466-Sharing-tickets-with-other-Zendesk-Support-accounts
+        Creates a sharing agreement. Requires sharing to be enabled on the Zendesk instance. For more information see: https://support.zendesk.com/hc/en-us/articles/203661466-Sharing-tickets-with-other-Zendesk-Support-accounts
     .EXAMPLE
         PS C:\> New-ZendeskSharingAgreement -RemoteSubdomain 'Foo'
 
         Creates a new sharing agreement with the Foo Zendesk Support instance.
     #>
     [OutputType([PSCustomObject])]
-    [CMDletBinding(SupportsShouldProcess = $true, ConfirmImpact = 'High')]
+    [CmdletBinding(SupportsShouldProcess = $true, ConfirmImpact = 'High')]
     Param (
         # Name of this sharing agreement
         [Parameter(Mandatory = $false)]

functions/Update-SharingAgreement.ps1

@@ -16,13 +16,13 @@ function Update-SharingAgreement {
     [CmdletBinding(SupportsShouldProcess = $true, ConfirmImpact = 'High')]
     Param (
         # Unique Id of the group to retrieve
-        [Parameter(Mandatory = $false)]
+        [Parameter(Mandatory = $true)]
         [ValidateRange(1, [Int64]::MaxValue)]
         [Int64]
         $Id,
 
-        # Unique Id of the group to retrieve
-        [Parameter(Mandatory = $false)]
+        # The status of the agreement
+        [Parameter(Mandatory = $true)]
         [ValidateSet('accepted', 'declined', 'pending', 'inactive')]
         [String]
         $Status,
@@ -43,7 +43,7 @@ function Update-SharingAgreement {
         }
     }
 
-    if ($PSCmdlet.ShouldProcess($Id, 'Update Group Name.')) {
+    if ($PSCmdlet.ShouldProcess($Id, 'Update Sharing Agreement.')) {
         $result = Invoke-Method -Context $Context -Method 'Put' -Path $path -Body $body -Verbose:$VerbosePreference
         $result
     }