Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport marble diagrams for Single from 3.x #6681

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

thiyagu-7
Copy link
Contributor

@thiyagu-7 thiyagu-7 commented Oct 17, 2019

This PR is to backport the marble images of Single class from 3.x. The method onErrorResumeWith does not exist in 2.x and hence I have left that out.

Closes #6679

@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #6681 into 2.x will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6681      +/-   ##
============================================
- Coverage     98.21%   98.19%   -0.02%     
+ Complexity     6349     6347       -2     
============================================
  Files           677      677              
  Lines         45550    45550              
  Branches       6333     6333              
============================================
- Hits          44735    44727       -8     
+ Misses          255      254       -1     
- Partials        560      569       +9
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Single.java 100% <ø> (ø) 149 <0> (ø) ⬇️
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...a/io/reactivex/internal/util/QueueDrainHelper.java 97.22% <0%> (-2.78%) 56% <0%> (-2%)
...nternal/operators/observable/ObservableWindow.java 98% <0%> (-2%) 3% <0%> (ø)
...nal/operators/observable/ObservablePublishAlt.java 94.39% <0%> (-1.87%) 14% <0%> (-1%)
.../operators/mixed/FlowableConcatMapCompletable.java 98.29% <0%> (-1.71%) 2% <0%> (ø)
...vex/internal/operators/single/SingleTakeUntil.java 98.3% <0%> (-1.7%) 2% <0%> (ø)
...ava/io/reactivex/processors/BehaviorProcessor.java 96.86% <0%> (-1.35%) 60% <0%> (+1%)
...l/operators/observable/ObservableFlatMapMaybe.java 89.54% <0%> (-1.31%) 2% <0%> (ø)
...perators/mixed/ObservableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 3% <0%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70fe91c...8dcb7ae. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants