Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.x: Backport marble fixes to Single #6679

Closed
akarnokd opened this issue Oct 17, 2019 · 4 comments
Closed

2.x: Backport marble fixes to Single #6679

akarnokd opened this issue Oct 17, 2019 · 4 comments
Labels
2.x Documentation good first issue PR welcome

Comments

@akarnokd
Copy link
Member

The main task is to locate the relevant methods and then copy-paste the <img> entry.

The diff in https://github.com/ReactiveX/RxJava/pull/6668/files should help.

In case of renamed operator(s), let me know and I'll post images for them.
@thiyagu-7
Copy link
Contributor

I'll take this up :)

@thiyagu-7
Copy link
Contributor

thiyagu-7 commented Oct 17, 2019 •
edited
Loading

The two using methods taking a Supplier as resourceSupplier in 3.x are taking a Callable in 2.x. Can I use the same image for these methods?

I guess the only change from 2.x to 3.x is to use a Supplier rather than a Callable. So, I suppose the marble image need not have any change for 2.x

I'll send a PR once you confirm this

@akarnokd
Copy link
Member Author

Use them for now, I'll create the appropriate images for them tomorrow.

This was referenced Oct 17, 2019
Closed
Merged
@akarnokd
Copy link
Member Author

Closing via #6681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x Documentation good first issue PR welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Backport marble diagrams for Single from 3.x thiyagu-7/RxJava
2 participants
@akarnokd @thiyagu-7