Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vararg issues reported in https://github.com/Netflix/RxJava/issues/359 #361

Merged
merged 7 commits into from
Sep 10, 2013
Merged

Fix vararg issues reported in https://github.com/Netflix/RxJava/issues/359 #361

merged 7 commits into from
Sep 10, 2013

Conversation

benjchristensen
Copy link
Member

Branch working on #359

I'll continue committing to this until all the varargs are replaced.

@benjchristensen
Observable.from: refactor varargs to overloads
2aabbd3 
ReactiveX#359 Varargs cause compiler warnings
@benjchristensen
Observable.concat: refactor varargs to overloads
1a0fcdc 
ReactiveX#359 Varargs cause compiler warnings

As part of this I also changed this:

```java
public static <T> Observable<T> concat(Observable<Observable<? extends T>> observables)
```

to

```java
public static <T> Observable<T> concat(Observable<Observable<T>> observables)
```

I documented the reasoning of this at ReactiveX#360 (comment)
@benjchristensen
Observable.merge: refactor varargs to overloads
969b3a9 
ReactiveX#359 Varargs cause compiler warnings
@benjchristensen
Observable.startWith: refactor varargs to overloads
284f79a 
ReactiveX#359 Varargs cause compiler warnings
@benjchristensen
Generic covariance of concat.
97b51eb 
See ReactiveX#360 (comment)
@benjchristensen
Observable.mergeDelayError: refactor varargs to overloads
5957881 
ReactiveX#359 Varargs cause compiler warnings
@cloudbees-pull-request-builder
Copy link

RxJava-pull-requests #253 SUCCESS
This pull request looks good

@benjchristensen
Copy link
Member Author

This seems to be working well so am merging it. This removes all vararg usage. It does increase surface area with multiple-arity overloads, but it's clean and displays well in an IDE.

I have chosen to use Observable<Observable<T>> on all of the overloads instead of Iterable<Observable<T>> since Observable is more generic and fits the Rx model. An Observable<Observable<T>> can easily be created from Iterable<Observable<T>> using Observable.from. If this is not liked we can add the Iterable overloads as well.

screen shot 2013-09-09 at 5 49 25 pm

benjchristensen added a commit that referenced this pull request Sep 10, 2013
@benjchristensen
Merge pull request #361 from benjchristensen/issue-359-varargs
96feb27 
Fix vararg issues reported in #359
@benjchristensen benjchristensen merged commit 96feb27 into ReactiveX:master Sep 10, 2013
@benjchristensen benjchristensen mentioned this pull request Sep 10, 2013
Closed
@cloudbees-pull-request-builder
Copy link

RxJava-pull-requests #254 SUCCESS
This pull request looks good

@benjchristensen benjchristensen mentioned this pull request Sep 10, 2013
Closed
@benjchristensen benjchristensen mentioned this pull request Dec 24, 2013
Closed
rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
@benjchristensen
Merge pull request ReactiveX#361 from benjchristensen/issue-359-varargs
d77d362 
Fix vararg issues reported in ReactiveX#359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benjchristensen @cloudbees-pull-request-builder @samuelgruetter @gbenson-nflx