-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Observable.from: refactor varargs to overloads
#359 Varargs cause compiler warnings
- Loading branch information
1 parent
ccc10cf
commit 2aabbd3
Showing
8 changed files
with
361 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
2aabbd3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am wondering what the reason was for changing Observable from(T... items) into a set of methods with individual signatures such as Observable from(T t1, T t2), etc.? Seems to create a more confusing API as well as really mucking things up for auto-completers...
2aabbd3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. The reason is #359 . Not respecting that would be even worse.
And if you want a nicer API, use the Scala adaptor (disclaimer: I wrote it ;-) )
2aabbd3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugly and unfortunate. Thanks for the clarification.
2aabbd3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is ugly and unfortunate. The vararg implementation in Java is very annoying how it's not type-safe.