Issue 329: Fix non-deterministic unit tests #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to fix non-determinism ReactiveX#329 Made unit tests work on private instances in each test rather than against static global.
Removed use of Thread.sleep to fix non-determinism issue reported in ReactiveX#329
Removed use of Thread.sleep and changed assertion to allow for the expected race condition between the counter loop and unsubscribe event to fix non-determinism issue reported in ReactiveX#329
Increased delta value from 2 to 10 to try and resolve issue reported in issue ReactiveX#329
Refactored to use BlockingObservable instead of non-blocking subscribe and waiting on the underlying thread (it was only waiting on one of two threads running). This should resolve one of the issues reported in http://github.com/Netflix/RxJava/issues/329
benjchristensen
added a commit
that referenced
this pull request
Aug 31, 2013
Issue 329: Fix non-deterministic unit tests
|
RxJava-pull-requests #214 FAILURE |
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
…tests Issue 329: Fix non-deterministic unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sure there are others, but I've tried to fix the ones reported in #329