Build is non-deterministic, failed 4 times in different places #329
Comments
|
Note that the build failure reported in #327 is one of the errors I encountered. |
|
More detail: this seems to be a Java 8 issue. It builds clean with 1.6. |
|
I have committed fixes for these that should behave better. There were legit issues in them that depended on specific machine and scheduler timing. I won't be surprised if there are other tests with similar issues in the codebase. |
|
Considering this closed ... reopen if you're still seeing these issues. |
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this issue
Jan 9, 2014
Attempt to fix non-determinism ReactiveX#329 Made unit tests work on private instances in each test rather than against static global.
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this issue
Jan 9, 2014
Removed use of Thread.sleep to fix non-determinism issue reported in ReactiveX#329
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this issue
Jan 9, 2014
Removed use of Thread.sleep and changed assertion to allow for the expected race condition between the counter loop and unsubscribe event to fix non-determinism issue reported in ReactiveX#329
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this issue
Jan 9, 2014
Increased delta value from 2 to 10 to try and resolve issue reported in issue ReactiveX#329
billyy
pushed a commit
to billyy/RxJava
that referenced
this issue
Jan 13, 2014
Attempt to fix non-determinism ReactiveX#329 Made unit tests work on private instances in each test rather than against static global.
billyy
pushed a commit
to billyy/RxJava
that referenced
this issue
Jan 13, 2014
Removed use of Thread.sleep to fix non-determinism issue reported in ReactiveX#329
billyy
pushed a commit
to billyy/RxJava
that referenced
this issue
Jan 13, 2014
Removed use of Thread.sleep and changed assertion to allow for the expected race condition between the counter loop and unsubscribe event to fix non-determinism issue reported in ReactiveX#329
billyy
pushed a commit
to billyy/RxJava
that referenced
this issue
Jan 13, 2014
Increased delta value from 2 to 10 to try and resolve issue reported in issue ReactiveX#329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reported as of commit 6a7ee812c7.
I've pasted a transcript as this gist.
All of the builds were executed in a single shell, with the same build command:
./gradlew clean build.The builds all failed for different reasons, suggesting timing dependencies in the unit tests.
The text was updated successfully, but these errors were encountered: