#535 search parents of click target in body mode #613
Conversation
BREAKING CHANGE: if a tooltip applies to a dom tree instead of a single element, a click on tree's children will now result displaying a tooltip if a data-tip attribute is found in parent chain of clicked dom element. This might affect code where children are not contained in the bounds of their parents #535
|
@idc-developer Are you using this branch in production? Do you have the dist hosted somewhere like on github? I'd like to use your branch in production if possible. |
|
Yes we do. We have forked it and committed the dist into our fork master: https://github.com/idc-developer/react-tooltip |
|
@idc-developer thank you for your work. Would it be possible to add the Although it's debatable since someone might expect that when you disable tooltip on child, tooltip on parent should take its place. |
The name seems not well fitting. Maybe you should name it like browser events "data-tip-stop-propagation". Currently I have no time to integrate this, but you could fork and do it yourself and create a pull request here. |
This will fix #535, reissued pull request after build sytem change to rollup