Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in bodyMode search parents of current target for tooltips #535

Closed
idc-developer opened this issue Jan 15, 2020 · 0 comments
Closed

in bodyMode search parents of current target for tooltips #535

idc-developer opened this issue Jan 15, 2020 · 0 comments

Comments

@idc-developer
Copy link

idc-developer commented Jan 15, 2020 •
edited by aronhelser
Loading

Switching to bodyMode left our tooltips non functional, since in svg e.g. a textbox often is composed of a <g><rect/><text/></g>, but the tooltip should popup everywhere inside the g, e.g.
<g data-tip="my tip"><rect/><text/></g>
But body mode will currently search the data-tip in rect if you click on the box with no text or <text> if you click on text.

bodyListener should search from e.target the parent chain for data-tips.
@idc-developer idc-developer mentioned this issue Jan 30, 2020
Closed
@idc-developer idc-developer mentioned this issue Jun 18, 2020
Closed
idc-developer pushed a commit to idc-developer/react-tooltip that referenced this issue Apr 27, 2022
feat(parent_body_mode): ReactTooltip#535 search parents for data-tip …
71da348 
…if in body mode
@idc-developer idc-developer mentioned this issue Apr 27, 2022
Merged
pdeszynski pushed a commit to pdeszynski/react-tooltip that referenced this issue Aug 3, 2022
@semantic-release-bot
chore(release): 4.3.0 [skip ci]
0086631 
# [4.3.0](v4.2.21...v4.3.0) (2022-08-03)

### Bug Fixes

* [ReactTooltip#759](https://github.com/pdeszynski/react-tooltip/issues/759) - Disable tooltip when disable prop changes ([8e9cca0](8e9cca0))
* **aftershow:** call afterShow only after state has fully updated ([54752e8](54752e8))
* effect and type not properly applied at first render ([a8d0e51](a8d0e51))
* **getposition:** no error when all placements outside ([249b925](249b925))
* performance issue caused by excessive use of clearTimeout/Interval ([22aea50](22aea50))
* **react18:** tip not hiding with React 18 StrictMode enabled ([83b72c6](83b72c6))
* set aria-describedby value wrong when custom id ([a04d26c](a04d26c))

### Features

* **component:** adding "padding" property to customize padding style ([9ae765a](9ae765a))
* **getposition:** support desired-place-list (by priority) ([982d89d](982d89d))
* **parent_body_mode:** [ReactTooltip#535](https://github.com/pdeszynski/react-tooltip/issues/535) search parents for data-tip if in body mode ([71da348](71da348))
github-actions bot pushed a commit that referenced this issue Oct 13, 2022
@semantic-release-bot
chore(release): 4.3.0 [skip ci]
f9e513e 
# [4.3.0](v4.2.21...v4.3.0) (2022-10-13)

### Bug Fixes

* [#759](#759) - Disable tooltip when disable prop changes ([8e9cca0](8e9cca0))
* **aftershow:** call afterShow only after state has fully updated ([54752e8](54752e8))
* effect and type not properly applied at first render ([a8d0e51](a8d0e51))
* **getposition:** no error when all placements outside ([249b925](249b925))
* performance issue caused by excessive use of clearTimeout/Interval ([22aea50](22aea50))
* **react18:** tip not hiding with React 18 StrictMode enabled ([83b72c6](83b72c6))
* set aria-describedby value wrong when custom id ([a04d26c](a04d26c))

### Features

* **component:** adding "padding" property to customize padding style ([9ae765a](9ae765a))
* **getposition:** support desired-place-list (by priority) ([982d89d](982d89d))
* **parent_body_mode:** [#535](#535) search parents for data-tip if in body mode ([71da348](71da348))
* **pencil:** readme updated to trigger next minor release (react 18 support release) ([bb9c79e](bb9c79e))
* **pencil:** readme updated to trigger next minor release (react 18 support release) ([3a6ec6c](3a6ec6c))
yuriisalo123 pushed a commit to yuriisalo123/react-tooltip that referenced this issue Jun 28, 2023
@semantic-release-bot
chore(release): 4.3.0 [skip ci]
e176fc9 
# [4.3.0](ReactTooltip/react-tooltip@v4.2.21...v4.3.0) (2022-10-13)

### Bug Fixes

* [#759](ReactTooltip/react-tooltip#759) - Disable tooltip when disable prop changes ([8e9cca0](ReactTooltip/react-tooltip@8e9cca0))
* **aftershow:** call afterShow only after state has fully updated ([54752e8](ReactTooltip/react-tooltip@54752e8))
* effect and type not properly applied at first render ([a8d0e51](ReactTooltip/react-tooltip@a8d0e51))
* **getposition:** no error when all placements outside ([249b925](ReactTooltip/react-tooltip@249b925))
* performance issue caused by excessive use of clearTimeout/Interval ([22aea50](ReactTooltip/react-tooltip@22aea50))
* **react18:** tip not hiding with React 18 StrictMode enabled ([83b72c6](ReactTooltip/react-tooltip@83b72c6))
* set aria-describedby value wrong when custom id ([a04d26c](ReactTooltip/react-tooltip@a04d26c))

### Features

* **component:** adding "padding" property to customize padding style ([9ae765a](ReactTooltip/react-tooltip@9ae765a))
* **getposition:** support desired-place-list (by priority) ([982d89d](ReactTooltip/react-tooltip@982d89d))
* **parent_body_mode:** [#535](ReactTooltip/react-tooltip#535) search parents for data-tip if in body mode ([71da348](ReactTooltip/react-tooltip@71da348))
* **pencil:** readme updated to trigger next minor release (react 18 support release) ([bb9c79e](ReactTooltip/react-tooltip@bb9c79e))
* **pencil:** readme updated to trigger next minor release (react 18 support release) ([3a6ec6c](ReactTooltip/react-tooltip@3a6ec6c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#535 search parents of click target in body mode
2 participants
@danielbarion @idc-developer