-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: (Youtube Revanced) general-ads patch causes application to crash on select videos #1550
Comments
Revert ReVanced/revanced-integrations#240 locally and check if it solves the issue. If it does, check if it really does without reverting it. |
Ignore - have seen the "Sources" option in Settings allows for a custom integration repository to be specified. Will try now. |
Hitting this issue when trying to patch using my forked repo with the reverted commit. Have restarted Manager after changing the repository, have tried clearing data and cache of Manager, and uninstalling/reinstalling without success. I can also see that someone else had a similar issue after changing their repository on XDA Will have to try to set up a local build environment on my PC to generate the patched APK later. |
Try the CLI. |
Successfully tested the reverted commit using Including full output here for reference (particularly as I got an error while patching
|
Your issue is related to ReVanced/revanced-patches-template#1568. |
Would you like me to try and build the latest commit of |
@rel0aded Thank you for debugging the issue. I have pushed a revert commit which fixes ReVanced/revanced-patches-template#1550. The other issue is related to ReVanced/revanced-patches-template#1568 and does not require further investigation. Thanks. |
## [2.157.1-dev.2](ReVanced/revanced-patches@v2.157.1-dev.1...v2.157.1-dev.2) (2023-01-28) ### Bug Fixes * **youtube:** resolve duplicate preference keys ([ReVanced#1550](ReVanced/revanced-patches#1550)) ([aafdb89](ReVanced/revanced-patches@5b751fc))
# [2.158.0](ReVanced/revanced-patches@v2.157.0...v2.158.0) (2023-01-29) ### Bug Fixes * **youtube/microg-support:** replace new permission ([3d1cce5](ReVanced/revanced-patches@69eb105)) * **youtube:** resolve duplicate preference keys ([ReVanced#1550](ReVanced/revanced-patches#1550)) ([aafdb89](ReVanced/revanced-patches@5b751fc)) ### Features * **irplus:** `remove-ads` patch ([ReVanced#1554](ReVanced/revanced-patches#1554)) ([9943a52](ReVanced/revanced-patches@c5c6c55))
Type
Error at runtime
Bug description
When playing select videos (such as https://www.youtube.com/watch?v=Mh1cEaNW-H8) on a Samsung Galaxy Tab S8+ on the latest firmware, with the latest Revanced Manager and latest "recommended" patches on recommended Youtube release causes the entire application to crash back to the launcher with no user error presented.
Through a binary search, I've managed to narrow down the crash to the
general-ads
patch. Disabling only this patch from the 45 recommended by ReVanced Manager causes the application to play the video as expected. There are no errors presented in the log during the patching process.This issue does not appear on all other videos (although another one from the same channel, and one from a different channel exhibited this behaviour), nor does the issue appear on affected videos on a Pixel 6 (running the same versions of ReVanced Manager/patches/Youtube).
Device: Samsung Galaxy Tab S8+ (not rooted)
Firmware: X800XXU2BVK4 (latest)
Youtube: v17.49.37
ReVanced Manager: v0.052
Patches: v2.146.0
Steps to reproduce
Relevant log output
Screenshots or videos
No response
Solution
general-ads
patch before patching.Additional context
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: