-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stuck at "creating working directory" #483
Comments
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Clearing app data fixed it for me. |
But it clears the Cert key too, that sucks. |
Did you exit the app while it was patching? |
Can't reproduce in this way. |
Not sure what you are saying. Please explain. |
I mean I tried to exit the app while patching as you said to reproduce this bug but I can't. |
I asked wether you exited the app; I didn't say you should. |
No, I didn't. |
Please attach a complete recording of the following steps to understand your issue better:
|
I had the exact same issue. Out of desperation, I turned off Adguard and tried again, and it works! So when stuck at creating work directory, it could be network issues. Try looking into that direction if you have the same problem. |
The manager version mentioned in this issue is very old. But the bug is still existing till date? Are any of the solutions mentioned above are of help? |
Yes it still exists in the latest version, and I was able to fix it by turning off my VPN based adblocker(adguard). |
One workaround is reinstalling the app |
Wouldn't that make it an issue of adguard and not the manager? |
Every time you're patching an app? |
Every time this issue occurs |
And how often does that happen? |
i dont know |
I can't reproduce it in recent releases. |
Yes and No.
There are multiple possibilities that could cause this problem, mine is just one of them. It happens in the latest version, and clearing data/cache or reinstalling app did not fix it for me. |
Now that you know what caused issue on your side implies that this issue is clearly solved. Not everyone is having the same issue and if you've tried opening the app without internet at some point you'll know that the app requires internet to function, atleast that's how things are for now. If you want to apply what you said in the first two points that's a different case and would be a feature request and not a bug. |
@oSumAtrIX or @Ushie, this bug report is no longer related to manager and can be closed right? |
Are you sure this issue is solved? |
Maybe the manager should stop when the connection is lost? |
The app should not require any connection to begin with. |
Is it correct? It definitely requires internet to download patches. |
That shouldn't be a requirement. Choosing sources locally should be always available. |
Ah yes, just checked again. Once the patch has been downloaded completely it could work without internet. |
The issue isn't related to manager as for the OP it was caused by adguard. |
I am not the OP. And I think displaying wrong/misleading information is a bug, not a feature request. |
I am not sure what you mean. |
Adguard causes the connection corrupted but Revanced Manager need to handle the case when it can't get patches. |
I agree with @terrytw. Yes it's not strictly a bug caused by Revanced in that case, but it's still a bug that effects Revanced and should therefor atleast be handled approriatly (no need to workaround, just show a normal HTTP/TCP error and cancel patching), especially since AG is probably not; or atleast won't be the only app causing this. And before we need to scramble our minds to find out whats wrong, just clearly indicate it's a network issue so we can report in the appropriate places. Ideally one would just make a wrapper method like send_request(url, ...) {
var err, response = original_send_request_method(...);
if (err =! null) {
if (console.exists) {
console.log(err);
} else {
show_popup(err);
}
}
return response;
} and use that where ever possible. |
Indeed, it may not even necessarily be an app, it could be a custom rom, an internet censorship, etc., anyway, user should be notified of the current situation. |
Thank you, it works! |
Can this considered as complete with the merge of ReVanced/revanced-patches#1114? |
If the issue still happens in the latest version of ReVanced Manager, open a new issue |
Type
Error while running the manager
Bug description
Steps to reproduce
Open vanced manager
Select youtube and any patch
Wait
Android version
Idk?
Manager version
Version 0.0.39 (39)
Target package name
youtube stock
Target package version.
17.43.36
Installation type
Root
Patches selected.
First one
Device logs (exported using Manager settings).
Installer logs (exported using Installer menu option) [unneeded if issue is not during patching].
No response
Screenshots or videos
No response
Solution
No response
Additional context
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: