Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support patching on ARMv7 by updating AAPT2 #2084

Merged
merged 1 commit into from
Jul 28, 2024
Merged

fix: Support patching on ARMv7 by updating AAPT2 #2084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/java/app/revanced/manager/patcher/aapt/Aapt.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import android.content.Context
import app.revanced.manager.patcher.LibraryResolver
import android.os.Build.SUPPORTED_ABIS as DEVICE_ABIS
object Aapt : LibraryResolver() {
private val WORKING_ABIS = setOf("arm64-v8a", "x86", "x86_64")
private val WORKING_ABIS = setOf("arm64-v8a", "x86", "x86_64", "armeabi-v7a")

fun supportsDevice() = (DEVICE_ABIS intersect WORKING_ABIS).isNotEmpty()

Expand Down
Binary file added app/src/main/jniLibs/armeabi-v7a/libaapt2.so
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<string name="select_app">Select an app</string>
<string name="select_patches">Select patches</string>

<string name="unsupported_architecture_warning">Patching on ARMv7 devices is not yet supported and will most likely fail.</string>
<string name="unsupported_architecture_warning">Patching on this device architecture is unsupported and will most likely fail.</string>
oSumAtrIX marked this conversation as resolved.
Show resolved Hide resolved

<string name="import_">Import</string>
<string name="import_bundle">Import patch bundle</string>
Expand Down
3 changes: 0 additions & 3 deletions docs/0_prerequisites.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ In order to use ReVanced Manager, certain requirements must be met.
## 🤝 Requirements

- An Android device running Android 8 or higher
- Any device architecture except ARMv7[^1]

[^1]: This constraint only applies to patches, that require patching APK resources which is why some patches may or may not work on ARMv7 architecture. You can find out, which architectures your device supports here: [⚙️ Configuring ReVanced Manager](2_4_settings.md#%E2%84%B9%EF%B8%8F-about).

## ⏭️ What's next

Expand Down