-
-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Support patching on ARMv7 by updating AAPT2 #2084
Conversation
Now that all architectures are fully supported, I think the entire architecture warning can be removed revanced-manager/app/src/main/java/app/revanced/manager/ui/screen/DashboardScreen.kt Lines 210 to 219 in 52a89b1
revanced-manager/app/src/main/java/app/revanced/manager/patcher/aapt/Aapt.kt Lines 7 to 9 in 52a89b1
|
That's not all architectures |
If you are talking about In addition, wasn't this warning necessary because armv7 aapt2 was unstable but still existed? |
nvm, I forgot about if users patched non-resource patches only |
The code can be kept as a pessimistic precaution. Its formely known as defensive programming |
Binary taken from run https://github.com/ReVanced/aapt2/actions/runs/9977958347