Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pr-build): sign debug apk #1231

Merged
merged 3 commits into from
Sep 4, 2023
Merged

ci(pr-build): sign debug apk #1231

merged 3 commits into from
Sep 4, 2023

Conversation

validcube
Copy link
Member

🤖 (pr-build) Sign debug build

This implement the suggested solution in #1230


SDBSuggested

@validcube validcube requested review from PalmDevs and Ushie September 3, 2023 06:15
@validcube validcube self-assigned this Sep 3, 2023
@validcube validcube linked an issue Sep 3, 2023 that may be closed by this pull request
@validcube validcube marked this pull request as draft September 3, 2023 06:32
@validcube validcube marked this pull request as ready for review September 3, 2023 06:36
@PalmDevs
Copy link
Member

PalmDevs commented Sep 3, 2023

Why is the check failing?

@validcube
Copy link
Member Author

@PalmDevs Why is the check failing?

Great question, I have no idea 💀

@validcube validcube merged commit 8bf08ff into dev Sep 4, 2023
@BenjaminHalko
Copy link
Member

@validcube Will this workflow fail if the pr branch is originating outside the repo due to lack of key reading privileges as mentioned here?

@oSumAtrIX oSumAtrIX deleted the ci(flutter)/sign_debug branch September 5, 2023 02:08
Ushie added a commit that referenced this pull request Sep 7, 2023
Ushie added a commit that referenced this pull request Sep 7, 2023
This reverts commit 8bf08ff, as it fails for PRs originating from forks
oSumAtrIX pushed a commit that referenced this pull request Sep 7, 2023
oSumAtrIX pushed a commit that referenced this pull request Sep 7, 2023
This reverts commit 8bf08ff, as it fails for PRs originating from forks
oSumAtrIX pushed a commit that referenced this pull request Sep 7, 2023
oSumAtrIX pushed a commit that referenced this pull request Sep 7, 2023
This reverts commit 8bf08ff, as it fails for PRs originating from forks
oSumAtrIX pushed a commit that referenced this pull request Sep 7, 2023
oSumAtrIX pushed a commit that referenced this pull request Sep 7, 2023
This reverts commit 8bf08ff, as it fails for PRs originating from forks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: sign debug build
4 participants