Skip to content

Commit

Permalink
ci(pr-build): revert "sign apk with keystore (#1231)"
Browse files Browse the repository at this point in the history
This reverts commit 8bf08ff, as it fails for PRs originating from forks
  • Loading branch information
Ushie authored and oSumAtrIX committed Sep 7, 2023
1 parent d121861 commit 5c73393
Showing 1 changed file with 1 addition and 18 deletions.
19 changes: 1 addition & 18 deletions .github/workflows/pr-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,26 +37,9 @@ jobs:
- name: Build with Flutter
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SIGNING_KEY_ALIAS: ${{ secrets.SIGNING_KEY_ALIAS }}
SIGNING_KEY_PASSWORD: ${{ secrets.SIGNING_KEY_PASSWORD }}
SIGNING_STORE_PASSWORD: ${{ secrets.SIGNING_KEYSTORE_PASSWORD }}
run: flutter build apk --debug
- name: Sign APK
id: sign_apk
uses: ilharp/sign-android-release@v1
with:
releaseDir: build/app/outputs/apk/debug
signingKey: ${{ secrets.SIGNING_KEYSTORE }}
keyStorePassword: ${{ secrets.SIGNING_KEYSTORE_PASSWORD }}
keyAlias: ${{ secrets.SIGNING_KEY_ALIAS }}
keyPassword: ${{ secrets.SIGNING_KEY_PASSWORD }}
- name: Get SHA short
id: vars
run: echo "sha_short=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT
- name: Add version to APK
run: mv ${{ steps.sign_apk.outputs.signedFile }} revanced-manager-debug-${{ steps.vars.outputs.sha_short }}.apk
- name: Upload build
uses: actions/upload-artifact@v3
with:
name: revanced-manager
path: revanced-manager-debug-${{ steps.vars.outputs.sha_short }}.apk
path: build/app/outputs/flutter-apk/app-debug.apk

0 comments on commit 5c73393

Please sign in to comment.