Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Split "Enable Universal Patches" setting #1161

Closed

Conversation

BenjaminHalko
Copy link
Member

The setting "Enable Universal Patches" used to enable universal patches & load unsupported apps, now it is split into 2 settings. This allows universal patches to be used without the need to also load a longer list of apps.

The setting "Enable Universal Patches" used to enable universal patches & load unsupported apps, now it is split into 2 settings. This allows universal patches to be used without the need to also load a longer list of apps.
@validcube validcube requested a review from Ushie August 27, 2023 23:02
@Ushie
Copy link
Member

Ushie commented Aug 27, 2023

Instead, I propose speeding up the loading of the apps screen

We could do it this way:

  • Load the apps that have patches from the patch bundle instead of installed apps
  • Now load the installed apps and for the patch count parameter you can count the amount of packages without explicit package compatibility and assign it to all of them

@BenjaminHalko
Copy link
Member Author

BenjaminHalko commented Aug 28, 2023

@Ushie I attempted to improve the loading speed here #1166

I suspect that it is the DeviceApps.getInstalledApplications and DeviceApps.getApp functions that are slowing it down, not getting the patch count for each app.

I did a test where it would get all installed apps but not add it to the list, thus skipping over getting the patch count. The overall time it takes to load stayed the same.

@BenjaminHalko BenjaminHalko changed the base branch from main to dev September 2, 2023 19:06
@oSumAtrIX oSumAtrIX force-pushed the dev branch 3 times, most recently from 9001caa to 5c73393 Compare September 7, 2023 23:14
@Ushie Ushie closed this Sep 15, 2023
@BenjaminHalko BenjaminHalko deleted the seperate-universal-setting branch September 15, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants