Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up rule policy contraction check #8851

Merged
merged 3 commits into from
Jun 9, 2021

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Jun 8, 2021

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge requested a review from samsucik June 8, 2021 12:36
@wochinge wochinge marked this pull request as ready for review June 8, 2021 12:36
Copy link
Contributor

@samsucik samsucik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wochinge 😍

@wochinge wochinge merged commit 690f8b8 into main Jun 9, 2021
@wochinge wochinge deleted the improvement/rulepolicy-prediction-performance branch June 9, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Including RulePolicy leads to infinite max_history being used to deduplicate training trackers
2 participants