Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RulePolicy prediction timings #8850

Closed
1 task
wochinge opened this issue Jun 8, 2021 · 3 comments
Closed
1 task

Improve RulePolicy prediction timings #8850

wochinge opened this issue Jun 8, 2021 · 3 comments
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/ml/policies Issues focused around rasa's dialogue management policies area:rasa-oss/performance Issues focused around the performance of `rasa` (e.g.number of handled requests per second) research:code-improvement type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@wochinge
Copy link
Contributor

wochinge commented Jun 8, 2021

Description of Problem: RulePolicy predictions are slow. This is especially noticeable during training when we check for contradictions. The reason for this is that we call _rule_key_to_state a lot when checking if a rule is applicable. For each time we are doing this we are loading the json which is encoding the rule.

This is a followup from this issue.

Examples (if relevant):

Definition of Done:

  • Determine a quicker way to encode / load the rule states (e.g. by unwrapping the jsons just once or use a faster mechanism to load the jsons)
@wochinge wochinge added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/performance Issues focused around the performance of `rasa` (e.g.number of handled requests per second) area:rasa-oss/ml/policies Issues focused around rasa's dialogue management policies labels Jun 8, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

Exalate commented:

stale[bot] commented:

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 9, 2022
@wochinge wochinge removed the stale label Jan 10, 2022
@danielenricocahall
Copy link
Contributor

danielenricocahall commented Mar 3, 2022

Exalate commented:

danielenricocahall commented:

Now that caching has been added as an enhancement, could another possible solution be using a more performance optimized JSON library (e.g; orjson, rapidjson)? And/or would it make sense to make the cache size configurable? Similar issue has been raised here

@rasabot-exalate rasabot-exalate added area:rasa-oss and removed type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Mar 15, 2022 — with Exalate Issue Sync
@m-vdb m-vdb added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework and removed type:maintenance labels Mar 16, 2022
@rasabot-exalate rasabot-exalate added area:rasa-oss_:ferris_wheel: area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. and removed type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss_:ferris_wheel: labels Mar 17, 2022 — with Exalate Issue Sync
@m-vdb m-vdb added the type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR label Oct 10, 2022
@m-vdb m-vdb removed the type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. label Dec 8, 2022
@sync-by-unito
Copy link

sync-by-unito bot commented Dec 19, 2022

➤ Maxime Verger commented:

💡 Heads up! We're moving issues to Jira: https://rasa-open-source.atlassian.net/browse/OSS.

From now on, this Jira board is the place where you can browse (without an account) and create issues (you'll need a free Jira account for that). This GitHub issue has already been migrated to Jira and will be closed on January 9th, 2023. Do not forget to subscribe to the corresponding Jira issue!

➡️ More information in the forum: https://forum.rasa.com/t/migration-of-rasa-oss-issues-to-jira/56569.

@m-vdb m-vdb closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/ml/policies Issues focused around rasa's dialogue management policies area:rasa-oss/performance Issues focused around the performance of `rasa` (e.g.number of handled requests per second) research:code-improvement type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

No branches or pull requests

5 participants