-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement train_step instead of overwriting fit #7438
Conversation
The results of the model regression tests do not match the results I got when I'm testing locally. Need to investigate that further. |
I profiled the memory usage while running master:train_step (commit 4ea8d8 - current head )train_step (commit 07d63c - before keras clear_session)Observations:
|
@joejuzl could you please give it a final review? |
#8085 should help to reduce the memory usage of the policy tests and stop the CI tests failing. |
@joejuzl thank you for updating the tests. Could you please merge your changes into this branch? There are some merge conflicts |
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)