Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce amount of memory required for our unit tests that are run on PRs #7947

Closed
Ghostvv opened this issue Feb 12, 2021 · 0 comments · Fixed by #8085
Closed

reduce amount of memory required for our unit tests that are run on PRs #7947

Ghostvv opened this issue Feb 12, 2021 · 0 comments · Fixed by #8085
Assignees
@joejuzl
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/ml 👁 All issues related to machine learning effort:atom-squad/4 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@Ghostvv
Copy link
Contributor

Ghostvv commented Feb 12, 2021

train_step PR #7438 is a corner stone PR that is blocking us from moving forward with implementing various features like separate validation dataset and partial dataset loading for big datasets.

The problem is that some tests in this PR fail due to OOM.

We tested individual commandsrasa train, rasa test, rasa shell individually and even though they require quite a bit of memory, they don't seem to be leaking.
@Ghostvv Ghostvv added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Feb 12, 2021
@Ghostvv Ghostvv mentioned this issue Feb 12, 2021
Closed
@TyDunn TyDunn added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss/ml 👁 All issues related to machine learning and removed type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR labels Feb 12, 2021
@wochinge wochinge added the effort:atom-squad/4 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. label Feb 12, 2021
@joejuzl joejuzl linked a pull request Mar 2, 2021 that will close this issue
Change policy test class fixtures to use class scope #8085
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joejuzl joejuzl

Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/ml 👁 All issues related to machine learning effort:atom-squad/4 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change policy test class fixtures to use class scope RasaHQ/rasa
4 participants
@joejuzl @Ghostvv @wochinge @TyDunn