rasa train nlu accepts domain
#6913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll review tomorrow as it's too late today. If that's too late, please request somebody else :-) |
|
No rush, it will wait for you 😄 |
wochinge
reviewed
Oct 6, 2020
| @@ -46,6 +46,7 @@ def set_train_core_arguments(parser: argparse.ArgumentParser): | |||
|
|
|||
| def set_train_nlu_arguments(parser: argparse.ArgumentParser): | |||
| add_config_param(parser) | |||
| add_domain_param(parser, default=None) | |||
There was a problem hiding this comment.
why making the default None? get_validated_path does a lot of magic and would automatically set it to None in case the default path does not exist.
There was a problem hiding this comment.
So that it's None in rasa train nlu --help, because we don't want to change the default behaviour.
There was a problem hiding this comment.
Why don't we wanna join the default behavior? And it doesn't change the default behavior anyway, right?
wochinge
approved these changes
Oct 6, 2020
| @@ -46,6 +46,7 @@ def set_train_core_arguments(parser: argparse.ArgumentParser): | |||
|
|
|||
| def set_train_nlu_arguments(parser: argparse.ArgumentParser): | |||
| add_config_param(parser) | |||
| add_domain_param(parser, default=None) | |||
There was a problem hiding this comment.
Why don't we wanna join the default behavior? And it doesn't change the default behavior anyway, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6635
Proposed changes:
rasa train nluaccepts domainStatus (please check what you already did):
black(please check Readme for instructions)