Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain should be made available for rasa train nlu command if it's available #6635

Closed
dakshvar22 opened this issue Sep 10, 2020 · 1 comment · Fixed by #6913
Closed

Domain should be made available for rasa train nlu command if it's available #6635

dakshvar22 opened this issue Sep 10, 2020 · 1 comment · Fixed by #6913
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework

Comments

@dakshvar22
Copy link
Contributor

dakshvar22 commented Sep 10, 2020

Part of #6638

Rasa version: master

Issue:

When issuing the command rasa train nlu, train_nlu is invoked inside rasa/train.py which does not have access to the domain. Since responses key can be defined in the domain file as well which may be needed for the response selector training, the file importer should get access to the domain as well if its available. Once that's done responses will be sync'ed with the NLU training data which was added as part of #6591.

Without this, currently running rasa train nlu with ResponseSelector in the pipeline will lead to warnings such as -

Your training data contains an example 'What is your name?...' for the chitchat/ask_name intent. You either need to add a response phrase or correct the intent for this example in your training data. If you intend to use Response Selector in the pipeline, the training may fail.

because these response templates were defined under the responses key in the domain file.

rasa train command works completely fine.

Command or request that led to error:

rasa train nlu
@dakshvar22 dakshvar22 added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. area:rasa-oss 🎡 Anything related to the open source Rasa framework and removed type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Sep 10, 2020
@degiz degiz added this to the post 2.0rc1 Rasa Open Source milestone Sep 11, 2020
@degiz degiz self-assigned this Sep 11, 2020
@wochinge
Copy link
Contributor

wochinge commented Oct 7, 2020

fixed by #6913

@wochinge wochinge closed this as completed Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants