Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ambiguous logging in DIETClassifier #5443

Closed
wants to merge 52 commits into from
Closed

Fixed ambiguous logging in DIETClassifier #5443

wants to merge 52 commits into from

Conversation

tttthomasssss
Copy link
Contributor

Proposed changes:

  • Improved logging as it was unclear whether a log message comes from DIETClassifier or a subclass.

Changes made:

  • added class name of caller to log message

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

erohmensing and others added 30 commits March 6, 2020 09:07
@erohmensing
update event broker docs
8d78ad8
@erohmensing @ricwo
Apply suggestions from code review
493bd67 
Co-Authored-By: ricwo <[email protected]>
@erohmensing
remove optional kafka install instructions
a267ff3
@erohmensing
update wording
266add4
@dakshvar22
add details
0143b18
@dakshvar22
updated dep
5c98b5c
@dakshvar22
fix ujson as well
78de28d
@erohmensing
update based on copy suggestions
0b5b48a
@erohmensing
update code examples
b6746c1
@erohmensing
Merge pull request #5378 from RasaHQ/message-broker
8e0ba59 
update event broker docs
@dakshvar22
made ujson flexible
ce61a53
@dakshvar22
Merge pull request #5397 from RasaHQ/bumpup_transformers
8c52fdd 
Update dependencies
@dakshvar22
docstrings to utils.hugging_face
0d3ce68
@dakshvar22
fix typo
c953af8
@dakshvar22
explain token id
7ac3c35
@dakshvar22
Merge pull request #5399 from RasaHQ/add_docstrings
e6d0ad0 
Add docstrings to transformers components
@indam23
add an example for unexpected user input; consitently call domain dom…
fb12872 
…ain.yml
@indam23
add an example for unexpected user input; consitently call domain dom…
82f82c2 
…ain.yml
@indam23
some more examples
6608e28
@indam23
links to sections
7e3e4ea
@indam23
updates for 1.8; checklists for tutorials; split up tutorials
db79360
@indam23
merge back to one tutorial
c6720e1
@indam23
move checklists to end
0a86af4
@wochinge
switch to newer 'async' syntax
3bc8e5f
@wochinge
clarify no-root user usage with sdk image
ddb6884
@wochinge
add changelog entry
28c9b3a
@Ghostvv
fix override config
81be3cc
@indam23
Merge pull request #5404 from RasaHQ/sdk-no-root
c266fa5 
explain no-root user for SDK image
@indam23 @akelad
Update docs/user-guide/building-assistants.rst
7ee1269 
Co-Authored-By: Akela Drissner-Schmid <[email protected]>
@indam23 @akelad
Update docs/user-guide/building-assistants.rst
091c093 
Co-Authored-By: Akela Drissner-Schmid <[email protected]>
Ghostvv and others added 18 commits March 11, 2020 20:24
@Ghostvv
set weight sparsity to 0 in embed intent classifier
1ac7513
@Ghostvv
update migration guide
30dddf3
@indam23 @akelad
Update docs/user-guide/building-assistants.rst
24316c4 
Co-Authored-By: Akela Drissner-Schmid <[email protected]>
@indam23 @akelad
Update docs/user-guide/building-assistants.rst
f4539fc 
Co-Authored-By: Akela Drissner-Schmid <[email protected]>
@indam23
change wording in checklists
ce2d83c
@indam23
Merge branch 'l2_l3_rebase' of github.com:RasaHQ/rasa into l2_l3_rebase
7d1a156
@Ghostvv
Merge pull request #5411 from RasaHQ/fix-config
9395e0c 
fix override config
@Ghostvv
merge 1.8.x
ae60453
@dakshvar22
review comments
6de98ec
@akelad
fixed a few typos
22bf575
@Ghostvv
Merge pull request #5413 from RasaHQ/fix_defaults
574731f 
set weight sparsity to 0 in embed intent classifier
@indam23
simplify checklist
69ed949
@indam23
checklist updates
2027c9c
@dakshvar22 @akelad
Apply suggestions from code review
6bf5975 
Co-Authored-By: Akela Drissner-Schmid <[email protected]>
@indam23
Merge pull request #5402 from RasaHQ/l2_l3_rebase
e9181c9 
L2 l3 rebase
@dakshvar22
Merge pull request #5395 from RasaHQ/update-tf-usage-docs
9c405de 
Update documentation for advanced tensorflow usage
@tttthomasssss
add class name of calling class to log message to avoid confusion in …
df53df8 
…case this is executed from a subclass
@tttthomasssss
add class name of calling class to log message to avoid confusion in …
de7fc15 
…case this is executed from a subclass
@CLAassistant
Copy link

CLAassistant commented Mar 18, 2020 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
6 out of 7 committers have signed the CLA.

✅ erohmensing
✅ dakshvar22
✅ Ghostvv
✅ melindaloubser1
✅ wochinge
✅ akelad
❌ thomas

thomas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tttthomasssss tttthomasssss requested a review from tabergma March 18, 2020 21:53
@tttthomasssss tttthomasssss self-assigned this Mar 18, 2020
@tttthomasssss tttthomasssss added this to the Rasa 1.9 milestone Mar 18, 2020
@tttthomasssss tttthomasssss added area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Mar 18, 2020
@tttthomasssss
Copy link
Contributor Author

Sorry, its late already today...

@tabergma tabergma mentioned this pull request Mar 20, 2020
Closed
@Ghostvv
Copy link
Contributor

Ghostvv commented Mar 23, 2020

it's closed not merged?

@tabergma
Copy link
Contributor

Sorry referenced wrong PR: #5444
@tttthomasssss I guess, you forgot to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabergma tabergma Awaiting requested review from tabergma

Assignees

@tttthomasssss tttthomasssss

Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
Rasa 1.9
Development

Successfully merging this pull request may close these issues.
9 participants
@tttthomasssss @CLAassistant @Ghostvv @tabergma @erohmensing @dakshvar22 @indam23 @wochinge @akelad