Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update event broker docs #5378

Merged
merged 6 commits into from
Mar 9, 2020
Merged

update event broker docs #5378

merged 6 commits into from
Mar 9, 2020

Conversation

erohmensing
Copy link
Contributor

Proposed changes:

  • Clarify messaging about message broker vs event broker (conversation)
  • clean up some old "Rasa Core" and unnecessary "endpoints configuration" stuff
  • add some TOCs for easier reading

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@erohmensing erohmensing requested review from ricwo and karen-white March 6, 2020 08:09
erohmensing
erohmensing commented Mar 6, 2020
View reviewed changes
docs/api/event-brokers.rst Show resolved Hide resolved
docs/api/event-brokers.rst Show resolved Hide resolved
ricwo
ricwo approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@ricwo ricwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 💯

docs/api/event-brokers.rst Show resolved Hide resolved
docs/api/event-brokers.rst Outdated Show resolved Hide resolved
docs/api/event-brokers.rst Outdated Show resolved Hide resolved
docs/api/event-brokers.rst Outdated Show resolved Hide resolved
docs/api/event-brokers.rst Outdated Show resolved Hide resolved
docs/api/event-brokers.rst Show resolved Hide resolved
karen-white
karen-white approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@karen-white karen-white left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

docs/api/event-brokers.rst Outdated Show resolved Hide resolved
docs/api/event-brokers.rst Outdated Show resolved Hide resolved
@erohmensing erohmensing merged commit 8e0ba59 into 1.8.x Mar 9, 2020
@erohmensing erohmensing deleted the message-broker branch March 9, 2020 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricwo ricwo ricwo approved these changes

@karen-white karen-white karen-white approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erohmensing @ricwo @karen-white