-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dockerfile to resolve errors #46
Update Dockerfile to resolve errors #46
Conversation
Updated ENV variables and added command to RUN variable to answer prompt
ENV DEBIAN_FRONTEND noninteractive | ||
ENV LANG=C.UTF-8 | ||
ENV LC_ALL=C.UTF-8 | ||
ENV DEBIAN_FRONTEND=noninteractive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://gist.github.com/jaamarks/e2c5c3c465b532e1610edc37d5649e93
Please review the above gist and implement the necessary changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variable changed based on recommendations in gist
Also,
|
RUN Rscript -e "install.packages(c('dplyr', 'httr', 'stringr','lubridate','sevenbridges2'), dependencies = T)" | ||
RUN Rscript -e "library('getopt');##### R SESSION INFORMATION #####; sessionInfo()" | ||
RUN Rscript -e "install.packages(c('getopt', 'dplyr', 'httr', 'stringr','lubridate','sevenbridges2'), dependencies = T)" | ||
RUN Rscript -e "library('getopt'); ##### R SESSION INFORMATION #####; sessionInfo()" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Why is
getopt
installed twice? - is there a reason why this is all on one line? If not, please put the comment and
sessionInfo()
command on a new line.
Updated ENV variables and added command to RUN variable to answer prompt
Description
Provide an overview...
Dockerfile Structure and Organization:
FROM ubuntu:20.04
instead ofFROM ubuntu
.Metadata
Include the following LABELs:
LABEL maintainer="Your Name <[email protected]>"
LABEL base-image="ubuntu:22.04"
LABEL description="Short description of the purpose of this image"
LABEL software-website="https://example.com"
LABEL software-version="1.0.0"
LABEL license="https://www.example.com/legal/end-user-software-license-agreement"
File and Resource Management:
/opt
.Container Behavior
CMD
to define how the container should run by default (help message is a good default).Assign reviewer