Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to resolve errors #46

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Update Dockerfile to resolve errors #46

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19ab7d8
Update Dockerfile to resolve errors
menger5 Aug 26, 2024
4486392
Change ENV variable to ARG and combine package install commands
menger5 Aug 26, 2024
9f712f0
Split RUN into multiple lines for readability
menger5 Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions update_metadata_bdc/v1.0.0/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@ LABEL about.tags="RMIP"
#----------------------------------------------------------------
# Install required command line tools and packages
#----------------------------------------------------------------
ENV LANG=C.UTF-8 LC_ALL=C.UTF-8
ENV DEBIAN_FRONTEND noninteractive
ENV LANG=C.UTF-8
ENV LC_ALL=C.UTF-8
ARG DEBIAN_FRONTEND noninteractive

RUN apt-get -qq update && apt-get -y upgrade && \
apt-get install -y --no-install-recommends \
Expand All @@ -30,7 +31,7 @@ RUN apt-get -qq update && apt-get -y upgrade && \
libxml2-dev \
build-essential && \
apt-get clean && \
apt-get autoremove
apt-get -y autoremove

#----------------------------------------------------------------
# Install R Packages
Expand All @@ -39,9 +40,8 @@ ENV R_VERSION 4.3.2

# Configure CRAN for package retrieval
RUN echo "r <- getOption('repos'); r['CRAN'] <- 'http://cran.us.r-project.org'; options(repos = r);" > ~/.Rprofile
RUN Rscript -e "install.packages('getopt', dependencies = T)"
RUN Rscript -e "install.packages(c('dplyr', 'httr', 'stringr','lubridate','sevenbridges2'), dependencies = T)"
RUN Rscript -e "library('getopt');##### R SESSION INFORMATION #####; sessionInfo()"
RUN Rscript -e "install.packages(c('getopt', 'dplyr', 'httr', 'stringr','lubridate','sevenbridges2'), dependencies = T)"
RUN Rscript -e "library('getopt'); ##### R SESSION INFORMATION #####; sessionInfo()"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Why is getopt installed twice?
  • is there a reason why this is all on one line? If not, please put the comment and sessionInfo() command on a new line.


#----------------------------------------------------------------
# Copy over analysis scripts
Expand Down