Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bsp][ESP32][esp32c3] add spi driver #9513

Merged
merged 8 commits into from
Oct 8, 2024
Merged

[bsp][ESP32][esp32c3] add spi driver #9513

merged 8 commits into from
Oct 8, 2024

Conversation

1078249029
Copy link
Contributor

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

issuse/5941

你的解决方案是什么 (what is your solution)

add the spi driver for esp32c3

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp/ESP32_C3
  • .config: RT_USING_SPI、BSP_USING_SPI、BSP_USING_SPI2
  • action:
    ]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@github-actions github-actions bot added the BSP label Oct 8, 2024
@CLAassistant
Copy link

CLAassistant commented Oct 8, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@1078249029 1078249029 changed the title Dev [bsp][ESP32][esp32c3] add spi driver Oct 8, 2024
@1078249029 1078249029 closed this Oct 8, 2024
@1078249029 1078249029 reopened this Oct 8, 2024
@1078249029
Copy link
Contributor Author

请问我在想我自己的仓库提交commit的时候没有触发workflow，需要我做什么？这是我第一次提交PR，有错误的地方希望前辈们多多担待

@1078249029
Copy link
Contributor Author

还有个问题是我提交的文件更改里有个rtconfig.py文件，这个文件配置了环境变量，但我的位置与主线的默认配置不同。我需要修改.gitignore再重新提交PR么

@1078249029 1078249029 mentioned this pull request Oct 8, 2024
Open
8 tasks
supperthomas
supperthomas requested changes Oct 8, 2024
View reviewed changes
bsp/ESP32_C3/drivers/drv_spi.c Outdated
*
* Change Logs:
* Date Author Notes
* 2021-12-20 BruceOu first implementation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢提交，这里可以写上自己的github名

bsp/ESP32_C3/drivers/drv_spi.h Outdated
*
* Change Logs:
* Date Author Notes
* 2021-12-20 BruceOu first implementation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

bsp/ESP32_C3/main/main.c Outdated

void spi_w25q_sample(void)
{
rt_hw_spi_device_attach(SPI_BUS_NAME, W25Q_SPI_DEVICE_NAME, GPIO_NUM_10 );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试代码不用提交

bsp/ESP32_C3/rtconfig.h Outdated

/* On-chip Peripheral Drivers */

#define BSP_USING_GPIO
#define BSP_USING_UART
#define BSP_USING_SPI
Copy link
Member

@supperthomas supperthomas Oct 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个默认可以不用开。

bsp/ESP32_C3/.config Outdated

#
# Data Processing
#
# CONFIG_PKG_USING_ARDUINO_KALMANFILTER is not set
# CONFIG_PKG_USING_ARDUINO_ARDUINOJSON is not set
# CONFIG_PKG_USING_ARDUINO_TENSORFLOW_LITE_MICRO is not set
# CONFIG_PKG_USING_ARDUINO_RUNNINGMEDIAN is not set
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.config rtconfig.h rtconfig.py 如果没有特别修改，不用提交。

@supperthomas
Copy link
Member

还有个问题是我提交的文件更改里有个rtconfig.py文件，这个文件配置了环境变量，但我的位置与主线的默认配置不同。我需要修改.gitignore再重新提交PR么

不用该.gitignore. 一般永远不git的，需要提交gitignore。 rtconfig.py还是属于需要修改的。
但是如果你当前PR rtconfig.py 没有特别功能修改，可以不用git提交。

@supperthomas
Copy link
Member

请问我在想我自己的仓库提交commit的时候没有触发workflow，需要我做什么？这是我第一次提交PR，有错误的地方希望前辈们多多担待

如果你想在你的branch触发workflow，你需要PR到你自己的repo的master上，并且改下action中的限制，action有限制。
你可以尝试手动触发，
到自己的repo下面打开action tab。 然后选择需要触发的workflow，然后选择自己的branch，可以参考下面的图片，手动触发测试。
image

@Rbb666 Rbb666 added the BSP: ESP32 BSP related with ESP label Oct 8, 2024
supperthomas
supperthomas requested changes Oct 8, 2024
View reviewed changes
bsp/ESP32_C3/main/main.c Outdated
@@ -10,6 +10,7 @@
* 2023-10-20 WCX1024979076 add wifi application
*/

#include "rttypes.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件没有特别修改，不用提交

supperthomas
supperthomas requested changes Oct 8, 2024
View reviewed changes
bsp/ESP32_C3/drivers/Kconfig Outdated
@@ -1,4 +1,5 @@

#include "rtconfig.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

？？？

@mysterywolf mysterywolf closed this Oct 8, 2024
@mysterywolf mysterywolf reopened this Oct 8, 2024
@mysterywolf mysterywolf merged commit a041584 into RT-Thread:master Oct 8, 2024
85 of 89 checks passed
@supperthomas
Copy link
Member

@mysterywolf CI 有报错
build stm32/stm32f407-rt-spark online-packages/multimedia/lvgl/lvgl-latest.attach failed.

@mysterywolf
Copy link
Member

我注意到了 LVGL上游主线新改了什么东西导致的，我在给他们提交PR

@1078249029 1078249029 deleted the dev branch October 25, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supperthomas supperthomas supperthomas approved these changes

Assignees
No one assigned
Labels
BSP: ESP32 BSP related with ESP BSP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@1078249029 @CLAassistant @supperthomas @mysterywolf @Rbb666