Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vk: Improve memory integrity #13070

Merged
merged 2 commits into from
Dec 14, 2022
Merged

vk: Improve memory integrity #13070

merged 2 commits into from
Dec 14, 2022

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Dec 13, 2022

  • Zero scratch vram allocations unless we're reusing a resource.
  • Introduce some extra barriers in copy_image_typeless. Without these some fast paths had back-to-back CmdCopyImageToBuffer and CmdCopyBufferToImage on the same scratch resource with 0 activity in between, causing garbage to get transferred in the second call and corrupting GPU memory.

Fixes #11328

This was referenced Dec 13, 2022
Open
Open
@Darkhost1999
Copy link
Contributor

NFS indeed is fixed. Setting recommendations welcome
https://youtu.be/kennE1Ip3Uo
NFS.log.gz
Water in GTAV is unchanged

@kd-11 kd-11 merged commit 7e35679 into RPCS3:master Dec 14, 2022
@kd-11 kd-11 deleted the zero-vram branch December 14, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Render: Vulkan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Regression] Need for Speed: Rivals [BLUS31201] Squid Ink
3 participants
@kd-11 @Darkhost1999 @Megamouse