Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3rdParty] Update MoltenVK to 1.3.236 & set MSL Fastmath to On Demand #13035

Merged
merged 6 commits into from
Dec 9, 2022
Merged

[3rdParty] Update MoltenVK to 1.3.236 & set MSL Fastmath to On Demand #13035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d4ae6e9
Update MoltenVK to 1.2.236
shinra-electric Dec 9, 2022
3aecb47
Change mvk_config.fastMathEnabled from a bool to Int
shinra-electric Dec 9, 2022
8adca34
Update device.cpp
shinra-electric Dec 9, 2022
5781ac9
Simplify fastMathEnabled to a ternary operator
shinra-electric Dec 9, 2022
ba78c32
Merge branch 'master' into update_MVK
shinra-electric Dec 9, 2022
f3cb6c4
Cleanup
shinra-electric Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 3rdparty/MoltenVK/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ include(ExternalProject)

ExternalProject_Add(moltenvk
GIT_REPOSITORY https://github.com/KhronosGroup/MoltenVK.git
GIT_TAG 260bad4
GIT_TAG a307b24
BUILD_IN_SOURCE 1
SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/MoltenVK
CONFIGURE_COMMAND "${CMAKE_CURRENT_SOURCE_DIR}/MoltenVK/fetchDependencies" --macos
Expand Down
2 changes: 1 addition & 1 deletion rpcs3/Emu/RSX/VK/vkutils/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ namespace vk
CHECK_RESULT_EX(_vkGetMoltenVKConfigurationMVK(VK_NULL_HANDLE, &mvk_config, &mvk_config_size), std::string("Could not get MoltenVK configuration."));

mvk_config.resumeLostDevice = true;
mvk_config.fastMathEnabled = !(g_cfg.video.disable_msl_fast_math.get());
mvk_config.fastMathEnabled = g_cfg.video.disable_msl_fast_math.get() ? MVK_CONFIG_FAST_MATH_NEVER : MVK_CONFIG_FAST_MATH_ON_DEMAND;

CHECK_RESULT_EX(_vkSetMoltenVKConfigurationMVK(VK_NULL_HANDLE, &mvk_config, &mvk_config_size), std::string("Could not set MoltenVK configuration."));
}
Expand Down