[3rdParty] Update MoltenVK to 1.3.236 & set MSL Fastmath to On Demand

[shinra-electric]

List of fixes and changes here.

Testing:
Check that the macOS CI build still works

[shinra-electric]

Error message:

/private/var/folders/xx/vl5f934s6k927z1vyyl9cxth0000gn/T/cirrus-ci-build/rpcs3/Emu/RSX/VK/vkutils/device.cpp:154:33: error: assigning to 'MVKConfigFastMath' from incompatible type 'bool'
                        mvk_config.fastMathEnabled = !(g_cfg.video.disable_msl_fast_math.get());
                                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

According to MVK this option is an enum, not a bool:

/** Identifies when Metal shaders will be compiled with the fast math option. */
typedef enum MVKConfigFastMath {
	MVK_CONFIG_FAST_MATH_NEVER     = 0,  /**< Metal shaders will never be compiled with the fast math option. */
	MVK_CONFIG_FAST_MATH_ALWAYS    = 1,  /**< Metal shaders will always be compiled with the fast math option. */
	MVK_CONFIG_FAST_MATH_ON_DEMAND = 2,  /**< Metal shaders will be compiled with the fast math option, unless the shader includes execution modes that require it to be compiled without fast math. */
	MVK_CONFIG_FAST_MATH_MAX_ENUM  = 0x7FFFFFFF
} MVKConfigFastMath;

Not sure what would be preferable, but I think NEVER for off, and ON_DEMAND for on?
It seems to be better than ALWAYS

[shinra-electric]

This is working now.

The GUI option is Off and On Demand. Having Always as an option seems a bit pointless.

However, I'm wondering if using On Demand by default makes the settings option useless? Should it just be removed from the GUI?

Or alternatively we could change the option from an on/off toggle to a dropdown with all three options?

Feedback appreciated.

[kd-11]

This is working now.

The GUI option is Off and On Demand. Having Always as an option seems a bit pointless.

However, I'm wondering if using On Demand by default makes the settings option useless? Should it just be removed from the GUI?

Or alternatively we could change the option from an on/off toggle to a dropdown with all three options?

Feedback appreciated.

I haven't read through the moltenVK code to figure out why this option is present. As for usefulness, its pretty much pointless as we have a global "shader quality" config as well that does a similar thing.

Outdated