Test and Enable OMNITRACE_BUILD_DYNINST, if needed #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test `find_package(Dyninst)` and if it is not found, then
enable OMNITRACE_BUILD_DYNINST and
DYNINST_BUILD_{TBB,BOOST,ELFUTILS,LIBIBERTY}.
Signed-off-by: David Galiffi <[email protected]>
dgaliffiAMD
force-pushed
the
cmake-test-dyninst
branch
from
1df8d31 to
5b9d7bc
Compare
ajanicijamd
approved these changes
Sep 12, 2024
|
I know this seems like a good idea but it isn’t. I used to deploy this strategy and it becomes really problematic when you have an external package installed and CMake isn’t finding it (or one of the external deps) for some reason. I’d highly advise against it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test
find_package(Dyninst)and if it is not found, then enable OMNITRACE_BUILD_DYNINST andDYNINST_BUILD_{TBB,BOOST,ELFUTILS,LIBIBERTY}.