rust: Update nightly version #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows more precise testing of changes that have stabilized.
|
False alarm, I was not testing on master but on a branch that left master before the last release. |
|
My tests wound up positive, and CI is also happy. |
|
bors merge |
|
Build succeeded: |
chrysn
added a commit
to chrysn-pull-requests/riotdocker
that referenced
this pull request
Sep 25, 2022
This is what RIOT-OS#204 should have been, but as that nightly build did not contain that day's rustc, the intended version was not installed.
bors bot
added a commit
that referenced
this pull request
Sep 26, 2022
207: rust: Update nightly version r=kaspar030 a=chrysn This is what #204 should have been, but as that nightly build did not contain that day's rustc, the intended version was not installed. --- I did tests back in #204, but they were about "do they existing things still work", not (what I couldn't test easily back then, as it'd have spanned many crates at once) "does it also have the intended effect of allowing stable use of all the new features". This unblocks RIOT-OS/rust-riot-wrappers#14, and would have made the rollback of RIOT-OS/RIOT#18642 (comment) unnecessary. Co-authored-by: chrysn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows more precise testing of changes that have stabilized. Concretely, all the changes (cstr in core, generic associated types) that have been stabilized available in the nightly in the form in which they will later be part of the releases.
Testing: CI should do (given it runs through representative builds), but I'm doing some extra tests (building out-of-tree examples) just to ensure that coverage is even better and make it even less likely to cause problems once a first full run is done on murdock.