Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: Update dependencies #18642

Merged
merged 1 commit into from
Sep 25, 2022
Merged

rust: Update dependencies #18642

merged 1 commit into from
Sep 25, 2022

Conversation

chrysn
Copy link
Member

@chrysn chrysn commented Sep 24, 2022

This will allow more components to build on 1.64 stable, and contains a fix relevant for #18619.

The versions of riot-sys and riot-wrappers referenced here will likely be tagged as the next releases for those once this PR is through.

Testing procedure

Green CI

Issues/PRs references

#18619 can be rebased onto this to fix the API-change-for-Rust it is causing.

@chrysn chrysn added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Area: Rust Area: Rust wrapper labels Sep 24, 2022
@chrysn chrysn requested a review from maribu September 24, 2022 20:07
@github-actions github-actions bot added Area: examples Area: Example Applications Area: sys Area: System Area: tests Area: tests and testing framework labels Sep 24, 2022
@chrysn
rust: Update dependencies
168ec76 
This will allow more components to build on 1.64 stable, and contains a
fix relevant for RIOT-OS#18619.

CoAP modules are held back as they appear to need an even newer nightly
than in the current riotdocker to build without feature declarations.
@chrysn
Copy link
Member Author

chrysn commented Sep 25, 2022

Thanks for clearing this.

I've rolled back some of the CoAP changes that build-failed because the library apparently assumes an even newer nightly (not that it's using new features, it's just not declaring them any more because they're now part of the beta release -- I though I'd set the nightly to just the one with which that works, but apparently I off-by-one'd); commit message amended with:

CoAP modules are held back as they appear to need an even newer nightly than in the current riotdocker to build without feature declarations.

I won't wait for a re-ack as this is strictly reducing the changes of this PR, and setting auto-merge.

@chrysn
Copy link
Member Author

chrysn commented Sep 25, 2022

There's one failing test run_test/tests/gnrc_ipv6_nib/samr21-xpro:gnu. This is so unrelated that after the rest has run through, I'll (or encourage anyone else as I might not be active on short timer) just set this to "skip" and merge it.

@chrysn chrysn mentioned this pull request Sep 25, 2022
Merged
@maribu maribu added CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Sep 25, 2022
@chrysn chrysn merged commit 976de15 into RIOT-OS:master Sep 25, 2022
@chrysn chrysn deleted the rust-20220924 branch September 25, 2022 16:36
bors bot added a commit to RIOT-OS/riotdocker that referenced this pull request Sep 26, 2022
@bors @chrysn
Merge #207
060e61f 
207: rust: Update nightly version r=kaspar030 a=chrysn

This is what #204 should have been, but as that nightly build did not contain that day's rustc, the intended version was not installed.

---

I did tests back in #204, but they were about "do they existing things still work", not (what I couldn't test easily back then, as it'd have spanned many crates at once) "does it also have the intended effect of allowing stable use of all the new features".

This unblocks RIOT-OS/rust-riot-wrappers#14, and would have made the rollback of RIOT-OS/RIOT#18642 (comment) unnecessary.

Co-authored-by: chrysn <[email protected]>
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@benpicco benpicco benpicco approved these changes

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: examples Area: Example Applications Area: Rust Area: Rust wrapper Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs
Projects
None yet
Milestone
Release 2022.10
Development

Successfully merging this pull request may close these issues.
3 participants
@chrysn @benpicco @maribu