Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

periph_usbdev: remove deprecated event flag #20488

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

dylad
Copy link
Member

@dylad dylad commented Mar 19, 2024

Contribution description

This PR removes a deprecated event flag in periph_usbdev.
This flag was only generated by sam0 periph_usbdev but was never used anywhere in usbus.
It was deprecated more than 2 years ago by #17046

Testing procedure

CI should be enough.

Issues/PRs references

None.

these interrupts were used to generate USBDEV_EVENT_TR_FAIL which is deprecated and will be removed

Signed-off-by: Dylan Laduranty <[email protected]>
@dylad dylad added the Process: removal Integration Process: The PR is removing a deprecated feature or API label Mar 19, 2024
@github-actions github-actions bot added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: drivers Area: Device drivers Area: cpu Area: CPU/MCU ports labels Mar 19, 2024
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an internal API anyway

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 19, 2024
@benpicco benpicco enabled auto-merge March 19, 2024 18:22
@riot-ci
Copy link

riot-ci commented Mar 19, 2024

Murdock results

✔️ PASSED

6fdc00a drivers/periph/usbdev: remove deprecated event flag

Success Failures Total Runtime
10008 0 10009 09m:54s

Artifacts

@benpicco benpicco added this pull request to the merge queue Mar 19, 2024
Merged via the queue into RIOT-OS:master with commit 17ec57e Mar 20, 2024
28 checks passed
@dylad
Copy link
Member Author

dylad commented Mar 20, 2024

Thanks @benpicco !

@dylad dylad deleted the pr/usbus/remove_deprecated_event branch March 20, 2024 11:45
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Process: removal Integration Process: The PR is removing a deprecated feature or API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants