usbdev/USBUS: deprecate transfer failure reporting report #17046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergzand
added
Type: cleanup
github-actions
bot
added
Area: drivers
bergzand
added
the
CI: ready for build
benpicco
approved these changes
Oct 25, 2021
bors bot
added a commit
that referenced
this pull request
Apr 21, 2023
19488: usbus: remove deprecated USBUS_HANDLER_FLAG_TR_FAIL flag r=gschorcht a=dylad ### Contribution description This PR removes the deprecated `USBUS_HANDLER_FLAG_TR_FAIL` flag. ### Testing procedure CI should be enough. ### Issues/PRs references Was deprecated by #17046 Co-authored-by: Dylan Laduranty <[email protected]>
bors bot
added a commit
that referenced
this pull request
Apr 21, 2023
19488: usbus: remove deprecated USBUS_HANDLER_FLAG_TR_FAIL flag r=gschorcht a=dylad ### Contribution description This PR removes the deprecated `USBUS_HANDLER_FLAG_TR_FAIL` flag. ### Testing procedure CI should be enough. ### Issues/PRs references Was deprecated by #17046 Co-authored-by: Dylan Laduranty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This deprecates the reporting of USB transfer failure (NAK). In 99% of the cases, reporting this back to higher layers is not useful as this indicates that the higher layer code had nothing to transfer when the host device polled us, which the higher layer code is probably already aware of.
Testing procedure
Check the added documentation deprecation notices.
Issues/PRs references
None