Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sock_dns_cache: move to dns_cache [backport 2022.07] #18327

Merged
merged 2 commits into from
Jul 19, 2022
Merged

sock_dns_cache: move to dns_cache [backport 2022.07] #18327

merged 2 commits into from
Jul 19, 2022

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jul 19, 2022

Backport of #18318

Contribution description

There is really no need for the DNS cache to be part of sock_dns and this makes it also usable for other DNS implementations and DNS protocols (such as DoC implemented in gcoap_dns)

Testing procedure

tests/unittests should still pass.

USEMODULE=dns_cache make tests/gnrc_sock_dns_dns -j test-with-config

should compile and succeed.

Issues/PRs references

Follow-up on #17680.

@miri64
net/dns: provide Kconfig
330614c 
(cherry picked from commit 1761726)
@miri64
sock_dns_cache: move to dns_cache
0119a58 
Also piggy-back some fixes to the unittests and submodule handling

(cherry picked from commit 8bec9c1)
@miri64 miri64 added Area: build system Area: Build system Area: Kconfig Area: Kconfig integration Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Jul 19, 2022
@miri64 miri64 requested a review from benpicco July 19, 2022 07:17
@miri64 miri64 mentioned this pull request Jul 19, 2022
Merged
@chrysn
Copy link
Member

chrysn commented Jul 19, 2022

It's not fixing a release spec failure ("Only bugfixes to address release specification test failures can be merged into the release branch after this date"), but as discussed in the original issue this makes sense to include in this release already (as otherwise we'd ship a feature incomplete and have an API change later).

Enabling auto-merge.

@chrysn chrysn enabled auto-merge July 19, 2022 08:16
@chrysn chrysn merged commit b75f789 into RIOT-OS:2022.07-branch Jul 19, 2022
@miri64 miri64 deleted the backport/2022.07/sock_dns_cache/cleanup/mv-dns_cache branch July 27, 2022 09:18
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen haukepetersen is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan cgundogan is a code owner

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: Kconfig Area: Kconfig integration Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @chrysn @benpicco