Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sock_dns_cache: move to dns_cache #18318

Merged
merged 2 commits into from
Jul 18, 2022
Merged

sock_dns_cache: move to dns_cache #18318

merged 2 commits into from
Jul 18, 2022

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jul 18, 2022

Contribution description

There is really no need for the DNS cache to be part of sock_dns and this makes it also usable for other DNS implementations and DNS protocols (such as DoC implemented in gcoap_dns)

Testing procedure

tests/unittests should still pass.

USEMODULE=dns_cache make tests/gnrc_sock_dns_dns -j test-with-config

should compile and succeed.

Issues/PRs references

Follow-up on #17680.

@miri64 miri64 added Area: network Area: Networking Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Jul 18, 2022
@miri64 miri64 added this to the Release 2022.07 milestone Jul 18, 2022
@github-actions github-actions bot added Area: build system Area: Build system Area: Kconfig Area: Kconfig integration Area: sys Area: System Area: tests Area: tests and testing framework labels Jul 18, 2022
@miri64
Copy link
Member Author

miri64 commented Jul 18, 2022

@chrysn would it be possible to backport this into the 2022.07 branch? It is an API change to quite a young feature, so I would prefer to have the introduction and the API change in the same release.

@chrysn
Copy link
Member

chrysn commented Jul 18, 2022

Sure makes sense -- before the API hits a release. I don't have time right now to review this PR, but if you can get it in at the RC1 (or RC2 if happens early) stage, I'd take it as a backport.

@miri64 miri64 changed the title Sock dns cache/cleanup/mv dns cache sock_dns_cache: move to dns_cache Jul 18, 2022
@miri64
Copy link
Member Author

miri64 commented Jul 18, 2022 •
edited
Loading

Then I would rather do it in the header, as the CFLAGS might conflict with Kconfig. ;-)

Done.

benpicco
benpicco approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash

@miri64 miri64 added the Area: doc Area: Documentation label Jul 18, 2022
@github-actions github-actions bot removed the Area: doc Area: Documentation label Jul 18, 2022
@miri64
sock_dns_cache: move to dns_cache
8bec9c1 
Also piggy-back some fixes to the unittests and submodule handling
@miri64 miri64 force-pushed the sock_dns_cache/cleanup/mv-dns_cache branch from cc0aaa8 to 8bec9c1 Compare July 18, 2022 13:28
@miri64
Copy link
Member Author

miri64 commented Jul 18, 2022

Squashed

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 18, 2022
@benpicco benpicco enabled auto-merge July 18, 2022 22:29
@benpicco benpicco added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Jul 18, 2022
@benpicco benpicco merged commit c547aa2 into RIOT-OS:master Jul 18, 2022
@miri64 miri64 deleted the sock_dns_cache/cleanup/mv-dns_cache branch July 19, 2022 07:15
@miri64 miri64 mentioned this pull request Jul 19, 2022
Merged
@miri64
Copy link
Member Author

miri64 commented Jul 19, 2022

Backport provided in #18327

This was referenced Jul 19, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: Kconfig Area: Kconfig integration Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2022.10
Development

Successfully merging this pull request may close these issues.
4 participants
@miri64 @chrysn @benpicco @maribu