Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/gcoap: introduce and use gcoap_resource_t #17804

Closed
wants to merge 1 commit into from
Closed

net/gcoap: introduce and use gcoap_resource_t #17804

wants to merge 1 commit into from

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Mar 14, 2022 •
edited
Loading

Contribution description

Use a separate type for gcoap resources so we can change callback types for nanocoap.

Testing procedure

This does not include any functional changes yet.

Issues/PRs references

split from #17544

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 14, 2022
@benpicco benpicco requested a review from kfessel March 14, 2022 13:06
@github-actions github-actions bot added Area: CoAP Area: Constrained Application Protocol implementations Area: examples Area: Example Applications Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework labels Mar 14, 2022
@benpicco benpicco mentioned this pull request Mar 14, 2022
Closed
2 tasks
@benpicco benpicco added the Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. label Mar 14, 2022
chrysn added a commit to chrysn-pull-requests/RIOT that referenced this pull request Mar 14, 2022
@chrysn
{examples,tests}/rust: Rust updates
c688fad 
These updates enable tests on beta (stable for the 2022.04 release) on
all platforms, and open the way for [17804].

[17804]: RIOT-OS#17804
@chrysn chrysn mentioned this pull request Mar 14, 2022
Merged
@benpicco benpicco added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Mar 15, 2022
@benpicco
Copy link
Contributor Author

Let's not go down this path

@benpicco benpicco closed this Apr 29, 2022
chrysn added a commit to RIOT-OS/rust-riot-sys that referenced this pull request May 31, 2022
@chrysn
Bump version
4f25cb7 
Changes:

* Use new gcoap_resource_t marker.

  This allows building branches of RIOT containing
  <RIOT-OS/RIOT#17804>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@kfessel kfessel Awaiting requested review from kfessel

Assignees
No one assigned
Labels
Area: CoAP Area: Constrained Application Protocol implementations Area: examples Area: Example Applications Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benpicco