Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{examples,tests}/rust: Rust updates #17806

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

chrysn
Copy link
Member

@chrysn chrysn commented Mar 14, 2022

Contribution description and PR references

These updates enable tests on beta (stable for the 2022.04 release) on
all platforms, and open the way for 17804.

Testing procedure

  • green CI

These updates enable tests on beta (stable for the 2022.04 release) on
all platforms, and open the way for [17804].

[17804]: RIOT-OS#17804
@chrysn chrysn added Area: Rust Area: Rust wrapper State: waiting for CI update State: The PR requires an Update to CI to be performed first labels Mar 14, 2022
@github-actions github-actions bot added Area: examples Area: Example Applications Area: tests Area: tests and testing framework labels Mar 14, 2022
@chrysn chrysn added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Mar 14, 2022
@chrysn chrysn requested a review from benpicco March 14, 2022 15:39
@chrysn chrysn mentioned this pull request Mar 14, 2022
@chrysn
Copy link
Member Author

chrysn commented Mar 14, 2022

CI only fails because tests were requested, and there they fail at build time (which passed on the more recently updated other hosts).

Removing the test runs and trying again; I don't think tests are critical here as the changes if anything would rather cause build than actual test failure, and on the ARM platform which the tests would run I've conducted some locally.

@chrysn chrysn added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer and removed CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR State: waiting for CI update State: The PR requires an Update to CI to be performed first labels Mar 14, 2022
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a simple update and CI is happy

@benpicco
Copy link
Contributor

Wait did I get it right that this will break the 'run tests' build? That would of course be silly - or was that a known sporadic failure?

@chrysn chrysn added CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 15, 2022
@chrysn
Copy link
Member Author

chrysn commented Mar 15, 2022

That was before the builders for the tests were updated, which AIU they are now. I've triggered another run with tests enabled just to be sure.

@chrysn chrysn enabled auto-merge March 15, 2022 06:17
@chrysn chrysn merged commit 7bcc673 into RIOT-OS:master Mar 15, 2022
@chrysn chrysn deleted the rust-update-20220314 branch March 15, 2022 06:22
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: examples Area: Example Applications Area: Rust Area: Rust wrapper Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants