Add the AODVv2 Routing Protocol #1767

Lotterleben · 2014-10-06T23:02:50Z

This PR depends on #1766.

It contains a minimal implementation of the AODVv2 routing protocol.
Not implemented are:

- AckReqs
- alternate metrics
- multiple interfaces
- clients and Client Networks
- buffering
- all addresses, TLVs, and features that are marked as optional

An example application can be found at https://github.com/Lotterleben/RIOT-AODVv2/tree/master/aodvv2_demo.

The implementation relies heavily on a functioning Neighbor Discovery Protocol.
It might be necessary to fill the neighbor cache manually with the current state
of RIOTs NDP implementation.

The value of AODVV2_MAX_UNREACHABLE_NODES has been chosen arbitrarily and will be subject to
future improvement.

Please note that based on my experience, with the default transceiver
buffer size (3) of the native port, about 2/3 of the route discoveries
will fail. This has been addressed in issue #1747. It is advised to increase
the transceiver buffer size when using AODVv2 as a routing protocol.

Lotterleben · 2014-10-07T10:15:20Z

I just noticed that Travis throws some style errors-- I remember
sys/net/routing/aodvv2/writer.c:142: error (arrayIndexOutOfBounds): Array '_rreq_addrtlvs[2]' accessed at index 3, which is out of bounds.
and the like being an error of cppcheck which I had encountered earlier as well. But I'll get to the other ones right away.

Lotterleben · 2014-10-07T10:16:01Z

@LudwigOrtmann Also, PR #1766 has been merged already. ;)

N8Fear · 2014-10-07T11:34:28Z

@Lotterleben Travis is unhappy because of the license headers of the following files:

file has an unknown license header: 'sys/net/include/aodvv2/aodvv2.h'
file has an unknown license header: 'sys/net/routing/aodvv2/aodv.c'
file has an unknown license header: 'sys/net/routing/aodvv2/aodv.h'
file has an unknown license header: 'sys/net/routing/aodvv2/constants.h'
file has an unknown license header: 'sys/net/routing/aodvv2/reader.c'
file has an unknown license header: 'sys/net/routing/aodvv2/reader.h'
file has an unknown license header: 'sys/net/routing/aodvv2/routing.c'
file has an unknown license header: 'sys/net/routing/aodvv2/routing.h'
file has an unknown license header: 'sys/net/routing/aodvv2/seqnum.c'
file has an unknown license header: 'sys/net/routing/aodvv2/seqnum.h'
file has an unknown license header: 'sys/net/routing/aodvv2/utils.c'
file has an unknown license header: 'sys/net/routing/aodvv2/utils.h'
file has an unknown license header: 'sys/net/routing/aodvv2/writer.c'
file has an unknown license header: 'sys/net/routing/aodvv2/writer.h'

OlegHahm · 2014-10-07T12:13:37Z

sys/net/include/aodvv2/aodvv2.h

+#ifndef AODVV2_H_
+#define AODVV2_H_
+
+void aodv_init(void);


This header would be happy about gettting documented. ;-)

LudwigKnuepfer · 2014-10-07T12:47:10Z

@Lotterleben Feel free to remove the obsolete tag yourself next time ;)

OlegHahm · 2014-10-07T12:48:19Z

sys/net/routing/aodvv2/aodv.c

+    if (ndp_nc_entry != NULL)
+    {
+
+        // Case 2: Broken Link (detected by lower layer)


C style comments please.

Lotterleben · 2014-10-07T12:48:33Z

@LudwigOrtmann Will do, wasn't sure if I was allowed to do that ;)

N8Fear · 2014-10-07T12:49:59Z

The cppcheck errors of the form sys/net/routing/aodvv2/writer.c:142: error (arrayIndexOutOfBounds): Array '_rreq_addrtlvs[2]' accessed at index 3, which is out of bounds. can be disabled by adding 'dummy array members' along the lines of [0] = { .type = NULL}, (the index should be adjusted accordingly).
I'm not sure if this is a problem in cppcheck or if this is an actual error. If it's an issue with cppcheck that should likely be reported upstream. The error should be blacklisted in your PR in the meantime.
Can you provide a link where this is documented as valid c99? (The question is essentially if it's ok to leave out members/indices of the struct).

Kijewski · 2014-11-10T22:20:00Z

sys/net/routing/aodvv2/writer.c

+{
+    AODV_DEBUG("%s()\n", __func__);
+    rfc5444_writer_cleanup(&writer);
+}


I dislike the prefix writer_. It's bound to clash with user code.

I used it for consistency with the oonf_api and Ben's OLSR code. I can rename it to aodv_packet_writer, but only after we've decided which is worse ugly newlines or long lines.

OlegHahm · 2014-11-11T16:59:32Z

In general I would like you to address the non-newline-realated comments that @Kijewski made. For the newlines, it's up to you if you want to obey strictly the 80-chars limit.

Lotterleben · 2014-11-11T18:38:10Z

@OlegHahm @Kijewski most of the unnecessary line breaks were made for consistency reasons. It seems weird to me to cram one ||-divided expression on one line and then split up the next one over two lines, and so on. If it's okay, I'd rather keep it this way (also because I have another deadline approaching and it's 23° C outside here ;) ) for now and if it ends up annoying somebody terribly, I'll fix it in another PR.
I'll take care of the other comments as soon as I can.

OlegHahm · 2014-11-11T18:55:54Z

Fair enough. Enjoy Honolulu and the cookies. ;)

OlegHahm · 2014-11-25T18:02:43Z

Just let me know (write here, use jabber, scream, wave your hands, ask @LudwigOrtmann to beat me...) when this is ready for the next review.

Lotterleben · 2014-11-25T18:25:01Z

@OlegHahm ACK, I'll notify you as soon as I'm done here... I hope I'll figure out why travis can't compile my stuff until then. :D

OlegHahm · 2014-11-26T00:43:43Z

sys/net/routing/aodvv2/utils.c:236: warning (pointerSize): Size of pointer 'dst' used instead of size of its data.
sys/net/routing/aodvv2/aodv.c:264: style (variableScope): The scope of the variable 'rcv_size' can be reduced.

Lotterleben · 2014-11-26T00:55:42Z

Oh, where did you get that from?

OlegHahm · 2014-11-26T08:58:38Z

Ran the Travis script manually locally. :-/ I think the || exit causes Travis to exit sometimes before it prints the error message. Need to look into this.

Lotterleben · 2014-11-26T09:10:41Z

I actually got rid of the || exit because it logged me out of my VM when the script was done a while ago, but I couldn't reproduce the messages...

miri64 · 2014-11-26T09:12:03Z

It's not related to this PR, but have you tried this?

{ foobar || exit } &
wait

Edit: added crucial &

OlegHahm · 2014-11-26T09:14:27Z

Opened #2089

N8Fear · 2014-11-27T08:02:58Z

Triaged in ~~#2089~~ #2101 but I guess that's an upstream cppcheck bug.

Edited: seems like I'm running too low on caffeine..

Lotterleben · 2014-11-27T08:11:01Z

Thank you! :)

OlegHahm · 2014-11-27T10:26:12Z

#2101 is merged, I guess you need to rebase on this.

Lotterleben · 2014-11-27T11:43:07Z

Travis is happy!

Let me just squash that again, 1sec...

This PR depends on RIOT-OS#1766. It contains a minimal implementation of the AODVv2 routing protocol. *Not* implemented are: - AckReqs - alternate metrics - multiple interfaces - clients and Client Networks - buffering - all addresses, TLVs, and features that are marked as optional An example application can be found at https://github.com/Lotterleben/RIOT-AODVv2/tree/master/aodvv2_demo. The implementation relies heavily on a functioning Neighbor Discovery Protocol. It might be necessary to fill the neighbor cache manually with the current state of RIOTs NDP implementation. The value of AODVV2_MAX_UNREACHABLE_NODES has been chosen arbitrarily and will be subject to future improvement. Please note that based on my experience, with the default transceiver buffer size (3) of the native port, about 2/3 of the route discoveries will fail. This has been addressed in issue RIOT-OS#1747. It is advised to increase the transceiver buffer size when using AODVv2 as a routing protocol.

Add the AODVv2 Routing Protocol

OlegHahm · 2014-11-27T13:14:24Z

Congrats!

emmanuelsearch · 2014-11-27T13:14:58Z

Congrats indeed ;)

LudwigKnuepfer added State: waiting for other PR State: The PR requires another PR to be merged first Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: network Area: Networking labels Oct 7, 2014

OlegHahm added the PR-award-nominee Deprecated. Will be removed soon. label Oct 7, 2014

Lotterleben force-pushed the aodvv2_PR branch from d884c9d to 541ede7 Compare October 7, 2014 11:43

OlegHahm reviewed Oct 7, 2014
View reviewed changes

LudwigKnuepfer removed the State: waiting for other PR State: The PR requires another PR to be merged first label Oct 7, 2014

OlegHahm reviewed Oct 7, 2014
View reviewed changes

sys/net/routing/aodvv2/aodv.c

if (ndp_nc_entry != NULL)

{

// Case 2: Broken Link (detected by lower layer)

Copy link

Member

OlegHahm Oct 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C style comments please.

Kijewski reviewed Nov 10, 2014
View reviewed changes

x3ro mentioned this pull request Nov 21, 2014

cppcheck behaves oddly regarding constStatement warnings #2067

Closed

Lotterleben force-pushed the aodvv2_PR branch from ae33b42 to 3f27d26 Compare November 25, 2014 17:35

Lotterleben force-pushed the aodvv2_PR branch from 566b9e1 to cb9724c Compare November 25, 2014 23:23

OlegHahm mentioned this pull request Nov 26, 2014

Travis errors w/o showing an error #2089

Closed

Lotterleben force-pushed the aodvv2_PR branch from b8a30fc to 0ca7d23 Compare November 27, 2014 10:41

Lotterleben force-pushed the aodvv2_PR branch from 0ca7d23 to 0c67c02 Compare November 27, 2014 11:52

OlegHahm added a commit that referenced this pull request Nov 27, 2014

Merge pull request #1767 from Lotterleben/aodvv2_PR

5ae6ca0

Add the AODVv2 Routing Protocol

OlegHahm merged commit 5ae6ca0 into RIOT-OS:master Nov 27, 2014

OlegHahm added this to the Release 2014.12 milestone Dec 2, 2014

miri64 mentioned this pull request Dec 3, 2014

sixlowpan: rename to sixlowpan_legacy #1967

Closed

jeandudey mentioned this pull request Sep 21, 2020

[WIP] RFC5444/MANET transport layer #15051

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add the AODVv2 Routing Protocol #1767

Add the AODVv2 Routing Protocol #1767

Lotterleben commented Oct 6, 2014

Lotterleben commented Oct 7, 2014

Lotterleben commented Oct 7, 2014

N8Fear commented Oct 7, 2014

OlegHahm Oct 7, 2014

LudwigKnuepfer commented Oct 7, 2014

OlegHahm Oct 7, 2014

Lotterleben commented Oct 7, 2014

N8Fear commented Oct 7, 2014

Kijewski Nov 10, 2014

Lotterleben Nov 11, 2014

OlegHahm commented Nov 11, 2014

Lotterleben commented Nov 11, 2014

OlegHahm commented Nov 11, 2014

OlegHahm commented Nov 25, 2014

Lotterleben commented Nov 25, 2014

OlegHahm commented Nov 26, 2014

Lotterleben commented Nov 26, 2014

OlegHahm commented Nov 26, 2014

Lotterleben commented Nov 26, 2014

miri64 commented Nov 26, 2014

OlegHahm commented Nov 26, 2014

N8Fear commented Nov 27, 2014

Lotterleben commented Nov 27, 2014

OlegHahm commented Nov 27, 2014

Lotterleben commented Nov 27, 2014

OlegHahm commented Nov 27, 2014

emmanuelsearch commented Nov 27, 2014

Add the AODVv2 Routing Protocol #1767

Add the AODVv2 Routing Protocol #1767

Conversation

Lotterleben commented Oct 6, 2014

Lotterleben commented Oct 7, 2014

Lotterleben commented Oct 7, 2014

N8Fear commented Oct 7, 2014

OlegHahm Oct 7, 2014

Choose a reason for hiding this comment

LudwigKnuepfer commented Oct 7, 2014

OlegHahm Oct 7, 2014

Choose a reason for hiding this comment

Lotterleben commented Oct 7, 2014

N8Fear commented Oct 7, 2014

Kijewski Nov 10, 2014

Choose a reason for hiding this comment

Lotterleben Nov 11, 2014

Choose a reason for hiding this comment

OlegHahm commented Nov 11, 2014

Lotterleben commented Nov 11, 2014

OlegHahm commented Nov 11, 2014

OlegHahm commented Nov 25, 2014

Lotterleben commented Nov 25, 2014

OlegHahm commented Nov 26, 2014

Lotterleben commented Nov 26, 2014

OlegHahm commented Nov 26, 2014

Lotterleben commented Nov 26, 2014

miri64 commented Nov 26, 2014

OlegHahm commented Nov 26, 2014

N8Fear commented Nov 27, 2014

Lotterleben commented Nov 27, 2014

OlegHahm commented Nov 27, 2014

Lotterleben commented Nov 27, 2014

OlegHahm commented Nov 27, 2014

emmanuelsearch commented Nov 27, 2014