tests/external-boards: add esp compile test boards #17525

fjmolinas · 2022-01-17T14:02:46Z

Contribution description

This PR wants to remove the dependencies against RIOT_CI_BUILD, it does so by adding esp BOARD clones that have the same dependencies added in #17314.

It currently only adds those BOARDs to tests/periph_timer, but it can be done for all tests where this would make sense @gschorcht should know which ones.

TODO:

Kconfig
Missing tests

Testing procedure

The new BOARDs show up make -C tests/periph_i2c/ info-boards | grep esp8266-ci

Murdock should build them

Check that the required modules are included.

Issues/PRs references

Came up in #17467
Related to #17314 and #12971

fjmolinas · 2022-01-17T14:07:15Z

@gschorcht if this works for you we could add these BOARDs to all applications where it would make sense!

gschorcht · 2022-01-17T14:57:15Z

@fjmolinas I'm absolutely fine with if it works in that way. Maybe we should use more the more generic boards esp32-wroom-32 and esp8286-esp-12x as base boards because esp32-wrover-kit is a very special full featured board.

fjmolinas · 2022-01-18T12:11:04Z

BTW I also want to mention (@leandrolanzieri asked about this offline) that if build time is a concern we could also have gone with #12971 but with only a single BOARD on the whitelist to achieve the same.

gschorcht · 2022-01-18T13:25:05Z

@fjmolinas The discussion about the virtual boards can be found in #17305 (comment) and following.

BTW I also want to mention (@leandrolanzieri asked about this offline) that if build time is a concern we could also have gone with #12971 but with only a single BOARD on the whitelist to achieve the same.

@benpicco's concern with PR #12971 was having full copies of test applications only for testing optional modules #12971 (review).

MrKevinWeiss · 2022-02-01T15:52:19Z

Just to sum some things up:

We there are optional modules available for esp32 and esp8266 boards.
These modules have some dependencies such as using software or hardware depending on if a peripheral is being used.
We are trying to find a clean way to test them.

Some possible solutions would be:

add a virtual board that is a copy of a board but with the extra features
add a test that brings the extra modules

Some questions are:

Should we try to optimise for a dimension, ie if we have 100 boards and 10 tests we should probably add to the boards?
Do the modules bring out different behaviour on different boards?
Do the modules bring out different behavior on different tests, maybe adding some delays that might change the outcome of tests?

We should try to get a solution some point soon at least. I see many out there...

fjmolinas · 2022-02-01T16:01:10Z

We should try to get a solution some point soon at least. I see many out there...

I personally like this virtual BOARD solution, I think it avoids cluttering the test directory and is something I was already suggesting in #12952. But this is only valid if we only want a compile test, if you would also
want to check behavior then different test applications are the way to go (or different configurations some time down the line)

gschorcht · 2022-02-01T16:54:59Z

We should try to get a solution some point soon at least. I see many out there...

I personally like this virtual BOARD solution, I think it avoids cluttering the test directory and is something I was already suggesting in #12952. But this is only valid if we only want a compile test, if you would also want to check behavior then different test applications are the way to go (or different configurations some time down the line)

Hmm, good question. Having a virtual board to cover optional modules in CI compilation would be a big step forward. Sure, optional modules that enable additional hardware like esp_spi_ram or another hardware implementation like esp_hw_counter would also require testing on real hardware. But the question is whether testing on hardware is the normal use case in CI. Most of the time CI is only used for compiling. Besides, esp_spi_ram for example requires a board, which is not available in CI anyway. Therefore the tests are done by the developer on real hardware with existing tests, in this case by me. Therefore, IMHO, having a virtual board would be great and sufficient for compilation in the CI.

gschorcht · 2022-02-01T16:55:42Z

It currently only adds those BOARDs to tests/periph_timer, but it can be done for all tests where this would make sense.

We should add some more tests for this board.

MrKevinWeiss · 2022-02-02T08:09:36Z

Besides, esp_spi_ram for example requires a board, which is not available in CI anyway.

I think we have on-target testing during nightlies for an esp32. If there were a test specifically for that then things like esp_spi_ram would be tested. Since we probably won't be using the virtual board in the CI it probably won't be tested.

That being said, having a clean solution that we can point saying "here is how a virtual board is implemented" is probably a good thing, especially if we can mark it. I am sure that others will require something like that. For that reason I would say we go ahead with this idea.

fjmolinas · 2022-02-02T08:54:30Z

I think we have on-target testing during nightlies for an esp32. If there were a test specifically for that then things like esp_spi_ram would be tested. Since we probably won't be using the virtual board in the CI it probably won't be tested.

That being said, having a clean solution that we can point saying "here is how a virtual board is implemented" is probably a good thing, especially if we can mark it. I am sure that others will require something like that. For that reason I would say we go ahead with this idea.

Ok, @MrKevinWeiss you had started modelling the Kconfig part in the PR that spawned this one, do you still have that somewhere?

MrKevinWeiss · 2022-02-02T08:57:14Z

Ok, @MrKevinWeiss you had started modelling the Kconfig part in the PR that spawned this one, do you still have that somewhere?

cough cough... I don't think so but also it wasn't done very well. I can provide a suggestion though, (before lunch)

gschorcht · 2022-02-02T10:45:52Z

I think we have on-target testing during nightlies for an esp32. If there were a test specifically for that then things like esp_spi_ram would be tested. Since we probably won't be using the virtual board in the CI it probably won't be tested.

I guess that during the nightlies a esp32-wroom-32 is used, which does not have the required feature esp_spi_ram to test the module esp_spi_ram. So it has to be tested explicitly on separate hardware anyway 😟

MrKevinWeiss · 2022-02-02T10:57:32Z

I think to hit that one on hardware I would just add a test specifically for that board, we can do that with a seperate PR I suppose.
Right now I actually think we need to figure out how to do the EXTERNAL_BOARD_DIRS. I think one issue is that configs are brought in by make in the makefile.include of the board we are trying to copy. I will need some time to play around with it.

MrKevinWeiss

I got something, it ain't pretty though...

diff --git a/.murdock b/.murdock
index c6f2b70f14..223370a237 100755
--- a/.murdock
+++ b/.murdock
@@ -31,7 +31,9 @@ cc1352-launchpad
 cc2650-launchpad
 derfmega128
 dwm1001
+esp32-ci
 esp32-heltec-lora32-v2
+esp8266-ci
 esp8266-esp-12x
 hamilton
 hifive1
@@ -88,6 +90,7 @@ tests/driver_s*
 tests/driver_t*
 tests/driver_u*
 tests/driver_v*
+tests/external_board_dirs
 tests/periph_*
 tests/pkg_elk
 tests/pkg_uzlib
diff --git a/boards/esp32-wrover-kit/Makefile.features b/boards/esp32-wrover-kit/Makefile.features
index 17054e8466..8724400f59 100644
--- a/boards/esp32-wrover-kit/Makefile.features
+++ b/boards/esp32-wrover-kit/Makefile.features
@@ -19,5 +19,5 @@ FEATURES_PROVIDED += arduino
 # This configuration enables modules that are only available when using Kconfig
 # module modelling
 ifeq (1, $(TEST_KCONFIG))
-  KCONFIG_ADD_CONFIG += $(BOARDDIR)/esp32-wrover-kit.config
+  KCONFIG_ADD_CONFIG += $(BOARDDIR)/$(BOARD).config
 endif
diff --git a/cpu/esp32/periph/Kconfig b/cpu/esp32/periph/Kconfig
index d9beb65cac..f3ecf0738b 100644
--- a/cpu/esp32/periph/Kconfig
+++ b/cpu/esp32/periph/Kconfig
@@ -27,4 +27,9 @@ config MODULE_PERIPH_RTT_HW_RTC
     bool
     default y if MODULE_PERIPH_RTT
 
+
+config MODULE_ESP_HW_COUNTER
+    bool "Use hardware counter"
+    depends on MODULE_PERIPH_TIMER
+
 endif # TEST_KCONFIG
diff --git a/cpu/esp32/periph/Kconfig.i2c b/cpu/esp32/periph/Kconfig.i2c
index fbbce1598b..fb4daba14b 100644
--- a/cpu/esp32/periph/Kconfig.i2c
+++ b/cpu/esp32/periph/Kconfig.i2c
@@ -7,7 +7,7 @@
 
 if TEST_KCONFIG
 
-choice
+choice ESP32_I2C_IMPLEMENTATION
     bool "I2C implementation"
     depends on MODULE_PERIPH_I2C
     help
diff --git a/cpu/esp8266/Kconfig b/cpu/esp8266/Kconfig
index 076fb92561..175c85b9dc 100644
--- a/cpu/esp8266/Kconfig
+++ b/cpu/esp8266/Kconfig
@@ -84,5 +84,9 @@ config MODULE_ESP_I2C_SW
     default y if MODULE_PERIPH_I2C
     select MODULE_PERIPH_I2C_SW
 
+config MODULE_ESP_SW_TIMER
+    bool "Use software timer"
+    depends on MODULE_PERIPH_TIMER
+
 rsource "sdk/Kconfig"
 rsource "vendor/Kconfig"
diff --git a/cpu/esp_common/Kconfig b/cpu/esp_common/Kconfig
index aef54697a0..cf5180cbd5 100644
--- a/cpu/esp_common/Kconfig
+++ b/cpu/esp_common/Kconfig
@@ -111,6 +111,13 @@ config MODULE_ESP_LOG_STARTUP
 
 endmenu
 
+config MODULE_ESP_HW_COUNTER
+    bool "Use hardware counter"
+    depends on MODULE_PERIPH_TIMER
+
+config MODULE_ESP_QEMU
+    bool "Simulate ESP with QEMU"
+
 endif # TEST_KCONFIG
 
 rsource "freertos/Kconfig"
diff --git a/tests/external_board_dirs/esp-ci-boards/esp32-ci/Kconfig b/tests/external_board_dirs/esp-ci-boards/esp32-ci/Kconfig
new file mode 100644
index 0000000000..2a9b3553b5
--- /dev/null
+++ b/tests/external_board_dirs/esp-ci-boards/esp32-ci/Kconfig
@@ -0,0 +1,49 @@
+# Copyright (c) 2020 HAW Hamburg
+#
+# This file is subject to the terms and conditions of the GNU Lesser
+# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+
+config BOARD
+    default "esp32-ci" if BOARD_ESP32_CI
+
+config BOARD_ESP32_CI
+    bool
+    default y
+    select BOARD_COMMON_ESP32
+    select CPU_MODEL_ESP32_WROVER
+    select HAS_ARDUINO
+    select HAS_ESP_RTC_TIMER_32K
+    select HAS_ESP_JTAG
+    select HAS_PERIPH_ADC
+    select HAS_PERIPH_I2C
+    select HAS_PERIPH_PWM
+    select HAS_PERIPH_SPI
+    select HAS_SDCARD_SPI
+
+    select MODULE_ESP_IDF_HEAP if TEST_KCONFIG
+    select MODULE_ESP_LOG_STARTUP if TEST_KCONFIG
+    select MODULE_ESP_LOG_TAGGED if TEST_KCONFIG
+    select MODULE_ESP_QEMU if TEST_KCONFIG
+    select MODULE_ESP_SPI_RAM if TEST_KCONFIG
+    select MODULE_ESP_HW_COUNTER if MODULE_PERIPH_TIMER
+
+    select HAVE_ILI9341
+
+
+if TEST_KCONFIG
+
+choice ESP32_I2C_IMPLEMENTATION
+    bool "I2C implementation"
+    depends on MODULE_PERIPH_I2C
+    default MODULE_ESP_I2C_HW
+    help
+      Due to the poor and faulty hardware I2C implementation the software one
+      is used by default for the moment.
+
+endchoice
+
+
+endif # TEST_KCONFIG
+
+source "$(RIOTBOARD)/common/esp32/Kconfig"
diff --git a/tests/external_board_dirs/esp-ci-boards/esp32-ci/esp32-ci.config b/tests/external_board_dirs/esp-ci-boards/esp32-ci/esp32-ci.config
new file mode 100644
index 0000000000..2b24cf45d3
--- /dev/null
+++ b/tests/external_board_dirs/esp-ci-boards/esp32-ci/esp32-ci.config
@@ -0,0 +1,2 @@
+# Sets up configuration for openocd
+CONFIG_MODULE_ESP_JTAG=y
diff --git a/tests/external_board_dirs/esp-ci-boards/esp8266-ci/Kconfig b/tests/external_board_dirs/esp-ci-boards/esp8266-ci/Kconfig
new file mode 100644
index 0000000000..9e7c52e1c0
--- /dev/null
+++ b/tests/external_board_dirs/esp-ci-boards/esp8266-ci/Kconfig
@@ -0,0 +1,23 @@
+# Copyright (c) 2020 HAW Hamburg
+#
+# This file is subject to the terms and conditions of the GNU Lesser
+# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+
+config BOARD
+    default "esp8266-ci" if BOARD_ESP8266_CI
+
+config BOARD_ESP8266_CI
+    bool
+    default y
+    select BOARD_COMMON_ESP8266
+    select CPU_MODEL_ESP8266_ESP_12X
+
+    select MODULE_ESP_LOG_TAGGED if TEST_KCONFIG
+    select MODULE_ESP_LOG_STARTUP if TEST_KCONFIG
+    select MODULE_ESP_QEMU if TEST_KCONFIG
+    select MODULE_ESP_SW_TIMER if MODULE_PERIPH_TIMER
+
+
+
+source "$(RIOTBOARD)/common/esp8266/Kconfig"

MrKevinWeiss · 2022-02-02T12:43:53Z

Some things that are up for discussion are:
Using the makefile.include to bring in a ${BOARD}.config... I think maybe we can just try to osource that for all instead of only specific boards that need it. I would like as little kconfig includes spread through the directories as possible.

Also the use of the something.config doesn't allow any conditionals, for example, if MODULE_PERIPH_TIMER is y then MODULE_ESP_HW_COUNTER.

I also don't know where we stand on the whole board selecting a module thing... For such simple modules maybe it make sense to keep it like that.

The final thing would be a general comment about the esp sw/hw choices. It seems like some are selectable and some are not. For example, ESP32_I2C_IMPLEMENTATION can be hardware or software. Would it make sense to have something like that for MODULE_ESP_SW_TIMER as well? Just to be explicit.

MrKevinWeiss · 2022-02-03T09:24:11Z

OK, after talking with @leandrolanzieri I think this is better (and I was able to test it locally)

diff --git a/.murdock b/.murdock
index c6f2b70f14..223370a237 100755
--- a/.murdock
+++ b/.murdock
@@ -31,7 +31,9 @@ cc1352-launchpad
 cc2650-launchpad
 derfmega128
 dwm1001
+esp32-ci
 esp32-heltec-lora32-v2
+esp8266-ci
 esp8266-esp-12x
 hamilton
 hifive1
@@ -88,6 +90,7 @@ tests/driver_s*
 tests/driver_t*
 tests/driver_u*
 tests/driver_v*
+tests/external_board_dirs
 tests/periph_*
 tests/pkg_elk
 tests/pkg_uzlib
diff --git a/boards/esp32-wrover-kit/Makefile.features b/boards/esp32-wrover-kit/Makefile.features
index 17054e8466..8724400f59 100644
--- a/boards/esp32-wrover-kit/Makefile.features
+++ b/boards/esp32-wrover-kit/Makefile.features
@@ -19,5 +19,5 @@ FEATURES_PROVIDED += arduino
 # This configuration enables modules that are only available when using Kconfig
 # module modelling
 ifeq (1, $(TEST_KCONFIG))
-  KCONFIG_ADD_CONFIG += $(BOARDDIR)/esp32-wrover-kit.config
+  KCONFIG_ADD_CONFIG += $(BOARDDIR)/$(BOARD).config
 endif
diff --git a/cpu/esp32/periph/Kconfig b/cpu/esp32/periph/Kconfig
index d9beb65cac..ec121a59e2 100644
--- a/cpu/esp32/periph/Kconfig
+++ b/cpu/esp32/periph/Kconfig
@@ -27,4 +27,8 @@ config MODULE_PERIPH_RTT_HW_RTC
     bool
     default y if MODULE_PERIPH_RTT
 
+config MODULE_ESP_HW_COUNTER
+    bool "Use hardware counter"
+    depends on MODULE_PERIPH_TIMER
+
 endif # TEST_KCONFIG
diff --git a/cpu/esp32/periph/Kconfig.i2c b/cpu/esp32/periph/Kconfig.i2c
index fbbce1598b..fb4daba14b 100644
--- a/cpu/esp32/periph/Kconfig.i2c
+++ b/cpu/esp32/periph/Kconfig.i2c
@@ -7,7 +7,7 @@
 
 if TEST_KCONFIG
 
-choice
+choice ESP32_I2C_IMPLEMENTATION
     bool "I2C implementation"
     depends on MODULE_PERIPH_I2C
     help
diff --git a/cpu/esp8266/Kconfig b/cpu/esp8266/Kconfig
index 076fb92561..175c85b9dc 100644
--- a/cpu/esp8266/Kconfig
+++ b/cpu/esp8266/Kconfig
@@ -84,5 +84,9 @@ config MODULE_ESP_I2C_SW
     default y if MODULE_PERIPH_I2C
     select MODULE_PERIPH_I2C_SW
 
+config MODULE_ESP_SW_TIMER
+    bool "Use software timer"
+    depends on MODULE_PERIPH_TIMER
+
 rsource "sdk/Kconfig"
 rsource "vendor/Kconfig"
diff --git a/cpu/esp_common/Kconfig b/cpu/esp_common/Kconfig
index aef54697a0..c6668b1f6c 100644
--- a/cpu/esp_common/Kconfig
+++ b/cpu/esp_common/Kconfig
@@ -111,6 +111,9 @@ config MODULE_ESP_LOG_STARTUP
 
 endmenu
 
+config MODULE_ESP_QEMU
+    bool "Simulate ESP with QEMU"
+
 endif # TEST_KCONFIG
 
 rsource "freertos/Kconfig"
diff --git a/tests/external_board_dirs/esp-ci-boards/esp32-ci/Kconfig b/tests/external_board_dirs/esp-ci-boards/esp32-ci/Kconfig
new file mode 100644
index 0000000000..5406aa99aa
--- /dev/null
+++ b/tests/external_board_dirs/esp-ci-boards/esp32-ci/Kconfig
@@ -0,0 +1,38 @@
+# Copyright (c) 2020 HAW Hamburg
+#
+# This file is subject to the terms and conditions of the GNU Lesser
+# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+
+config BOARD
+    default "esp32-ci" if BOARD_ESP32_CI
+
+config BOARD_ESP32_CI
+    bool
+    default y
+    select BOARD_COMMON_ESP32
+    select CPU_MODEL_ESP32_WROVER
+    select HAS_ARDUINO
+    select HAS_ESP_RTC_TIMER_32K
+    select HAS_ESP_JTAG
+    select HAS_PERIPH_ADC
+    select HAS_PERIPH_I2C
+    select HAS_PERIPH_PWM
+    select HAS_PERIPH_SPI
+    select HAS_SDCARD_SPI
+
+    select HAVE_ILI9341
+
+if TEST_KCONFIG
+
+choice ESP32_I2C_IMPLEMENTATION
+    default MODULE_ESP_I2C_HW
+endchoice
+
+config MODULE_ESP_HW_COUNTER
+    default y
+    depends on MODULE_PERIPH_TIMER
+
+endif # TEST_KCONFIG
+
+source "$(RIOTBOARD)/common/esp32/Kconfig"
diff --git a/tests/external_board_dirs/esp-ci-boards/esp32-ci/esp32-ci.config b/tests/external_board_dirs/esp-ci-boards/esp32-ci/esp32-ci.config
new file mode 100644
index 0000000000..4586b7c158
--- /dev/null
+++ b/tests/external_board_dirs/esp-ci-boards/esp32-ci/esp32-ci.config
@@ -0,0 +1,7 @@
+# Sets up configuration for openocd
+CONFIG_MODULE_ESP_JTAG=y
+CONFIG_MODULE_ESP_IDF_HEAP=y
+CONFIG_MODULE_ESP_LOG_STARTUP=y
+CONFIG_MODULE_ESP_LOG_TAGGED=y
+CONFIG_MODULE_ESP_QEMU=y
+CONFIG_MODULE_ESP_SPI_RAM=y
diff --git a/tests/external_board_dirs/esp-ci-boards/esp8266-ci/Kconfig b/tests/external_board_dirs/esp-ci-boards/esp8266-ci/Kconfig
new file mode 100644
index 0000000000..f791329e25
--- /dev/null
+++ b/tests/external_board_dirs/esp-ci-boards/esp8266-ci/Kconfig
@@ -0,0 +1,21 @@
+# Copyright (c) 2020 HAW Hamburg
+#
+# This file is subject to the terms and conditions of the GNU Lesser
+# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+
+config BOARD
+    default "esp8266-ci" if BOARD_ESP8266_CI
+
+config BOARD_ESP8266_CI
+    bool
+    default y
+    select BOARD_COMMON_ESP8266
+    select CPU_MODEL_ESP8266_ESP_12X
+
+config MODULE_ESP_SW_TIMER
+    default y
+    depends on TEST_KCONFIG
+    depends on MODULE_PERIPH_TIMER
+
+source "$(RIOTBOARD)/common/esp8266/Kconfig"
diff --git a/tests/external_board_dirs/esp-ci-boards/esp8266-ci/Makefile.features b/tests/external_board_dirs/esp-ci-boards/esp8266-ci/Makefile.features
index 5ebe212f55..2ad25ff5c4 100644
--- a/tests/external_board_dirs/esp-ci-boards/esp8266-ci/Makefile.features
+++ b/tests/external_board_dirs/esp-ci-boards/esp8266-ci/Makefile.features
@@ -1 +1,5 @@
 include $(RIOTBOARD)/esp8266-olimex-mod/Makefile.features
+
+ifeq (1, $(TEST_KCONFIG))
+  KCONFIG_ADD_CONFIG += $(BOARDDIR)/$(BOARD).config
+endif
diff --git a/tests/external_board_dirs/esp-ci-boards/esp8266-ci/esp8266-ci.config b/tests/external_board_dirs/esp-ci-boards/esp8266-ci/esp8266-ci.config
new file mode 100644
index 0000000000..e846e7274f
--- /dev/null
+++ b/tests/external_board_dirs/esp-ci-boards/esp8266-ci/esp8266-ci.config
@@ -0,0 +1,4 @@
+# Sets up configuration for openocd
+CONFIG_MODULE_ESP_LOG_STARTUP=y
+CONFIG_MODULE_ESP_LOG_TAGGED=y
+CONFIG_MODULE_ESP_QEMU=y

fjmolinas · 2022-02-04T07:25:34Z

I applied your suggestion, and rebased to fix the conflict

MrKevinWeiss · 2022-02-08T14:40:46Z

This is the last piece to the kconfig puzzle.

It seems that there is only one issue:

-- running on worker mobi3-0 thread 8, build number 2771.
make: Entering directory '/tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/tests/driver_lsm6dsl'
rm -rf /tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/build/pkg-build/esp8266_sdk
make: Leaving directory '/tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/tests/driver_lsm6dsl'
make: Entering directory '/tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/tests/driver_lsm6dsl'
[INFO] cloning esp8266_sdk
Building application "tests_driver_lsm6dsl" for "esp8266-esp-12x" with MCU "esp8266".

git-cache: cloning from cache. tag=commit913a06a9ac3b2f18009e8fee8f092ca9ffeccd38-2013188
[INFO] updating esp8266_sdk /tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/build/pkg/esp8266_sdk/.pkg-state.git-downloaded
echo 913a06a9ac3b2f18009e8fee8f092ca9ffeccd38 > /tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/build/pkg/esp8266_sdk/.pkg-state.git-downloaded
[INFO] patch esp8266_sdk
   text	   data	    bss	    dec	    hex	filename
 282724	   5300	  28760	 316784	  4d570	/tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/build/tests_driver_lsm6dsl.elf
esptool.py v2.4.0
Parsing CSV input...
sha1sum /tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/build/tests_driver_lsm6dsl.elf /tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/build/tests_driver_lsm6dsl.elf.bin /tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/build/partitions.bin > /tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/build/test-input-hash.sha1
make: Leaving directory '/tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/tests/driver_lsm6dsl'
make: Entering directory '/tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/tests/driver_lsm6dsl'
Building application "tests_driver_lsm6dsl" for "esp8266-esp-12x" with MCU "esp8266".
rm -rf /tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/build/pkg-build/esp8266_sdk

[INFO] cloning esp8266_sdk
git-cache: cloning from cache. tag=commit913a06a9ac3b2f18009e8fee8f092ca9ffeccd38-2025523
[INFO] updating esp8266_sdk /tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/build/pkg/esp8266_sdk/.pkg-state.git-downloaded
echo 913a06a9ac3b2f18009e8fee8f092ca9ffeccd38 > /tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/build/pkg/esp8266_sdk/.pkg-state.git-downloaded
[INFO] patch esp8266_sdk
   text	   data	    bss	    dec	    hex	filename
 282964	   5300	  28760	 317024	  4d660	/tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/build/tests_driver_lsm6dsl.elf
esptool.py v2.4.0
Parsing CSV input...
sha1sum /tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/build/tests_driver_lsm6dsl.elf /tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/build/tests_driver_lsm6dsl.elf.bin /tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/build/partitions.bin > /tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/build/test-input-hash.sha1
make: Leaving directory '/tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/tests/driver_lsm6dsl'
Hashes of binaries with and without Kconfig mismatch for tests/driver_lsm6dsl with esp8266-esp-12x
Please check that all used modules are modelled in Kconfig and enabled
rm -rf /tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/build/pkg-build/esp8266_sdk
rm -rf /tmp/dwq.0.16818261895240083/84aacbbabc36408c3a7745fd831944ad/build/pkg-build/esp8266_sdk
-- build directory size: 96K

This doesn't really even seem to be part of this board issue... The fact that there is no module difference is a bit odd. If nobody looks at this then I can give it a try tomorrow.

MrKevinWeiss · 2022-02-08T14:41:45Z

Maybe it would also be good to see if anyone is against the concept?

MrKevinWeiss · 2022-02-09T09:59:43Z

Hmm I cannot reproduce this locally... Maybe a rebase and remove the esp boards from the .murdock kconfig blocklist.

You may squash if you choose.

fjmolinas · 2022-02-09T10:03:14Z

Hmm I cannot reproduce this locally... Maybe a rebase and remove the esp boards from the .murdock kconfig blocklist.

You may squash if you choose.

Lets give it another run then, I've seen some spurious failures in murdock recently

fjmolinas · 2022-02-09T10:03:47Z

It currently only adds those BOARDs to tests/periph_timer, but it can be done for all tests where this would make sense.

We should add some more tests for this board.

@gschorcht could you suggest an adequate list?

fjmolinas · 2022-02-09T15:41:09Z

@MrKevinWeiss failures are because of disk errors, should I just squash?

MrKevinWeiss · 2022-02-09T15:47:24Z

Yes please

This adds esp board clones for compile testing

fjmolinas · 2022-02-09T15:50:30Z

It currently only adds those BOARDs to tests/periph_timer, but it can be done for all tests where this would make sense.

We should add some more tests for this board.

@gschorcht could you suggest an adequate list?

I think we can expand on a follow up as well :)

fjmolinas · 2022-02-10T07:03:27Z

All green @MrKevinWeiss

MrKevinWeiss

ACK

MrKevinWeiss · 2022-02-10T07:31:02Z

We can also remove the esps from the blocklist but we can save that for a later PR, the merge conflicts are real....

fjmolinas requested review from aabadie, gschorcht, leandrolanzieri, MichelRottleuthner and smlng as code owners January 17, 2022 14:02

github-actions bot added Area: boards Area: Board ports Area: tests Area: tests and testing framework labels Jan 17, 2022

fjmolinas mentioned this pull request Jan 17, 2022

board/*/kconfig: Fix boards on kconfig blocklist #17467

Merged

MrKevinWeiss reviewed Feb 2, 2022

View reviewed changes

fjmolinas requested review from cgundogan, jia200x and kaspar030 as code owners February 4, 2022 07:24

boards/esp*: revert optional modules used only in CI

8d12479

github-actions bot added Area: CI Area: Continuous Integration of RIOT components Area: cpu Area: CPU/MCU ports labels Feb 4, 2022

github-actions bot added Area: Kconfig Area: Kconfig integration Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Feb 4, 2022

fjmolinas force-pushed the pr_esp_compile_test_boards branch from 33be1a2 to 0036090 Compare February 4, 2022 07:25

fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 4, 2022

fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 9, 2022

fjmolinas added 4 commits February 9, 2022 16:50

tests/external_board_dirs: add esp ci boards

4e72d17

This adds esp board clones for compile testing

tests/periph_i2c: include esp ci compile test boards

a5aa948

cpu/esp: model missing modules

c1238ad

.murdock: add esp virtual boards

a19fc10

fjmolinas force-pushed the pr_esp_compile_test_boards branch from 0036090 to a19fc10 Compare February 9, 2022 15:50

MrKevinWeiss approved these changes Feb 10, 2022

View reviewed changes

MrKevinWeiss merged commit d97eed5 into RIOT-OS:master Feb 10, 2022

fjmolinas deleted the pr_esp_compile_test_boards branch February 10, 2022 08:04

fjmolinas changed the title ~~[POC] tests/external-boards: add esp compile test boards~~ tests/external-boards: add esp compile test boards Feb 10, 2022

OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests/external-boards: add esp compile test boards #17525

tests/external-boards: add esp compile test boards #17525

fjmolinas commented Jan 17, 2022

fjmolinas commented Jan 17, 2022

gschorcht commented Jan 17, 2022

fjmolinas commented Jan 18, 2022

gschorcht commented Jan 18, 2022

MrKevinWeiss commented Feb 1, 2022

fjmolinas commented Feb 1, 2022

gschorcht commented Feb 1, 2022

gschorcht commented Feb 1, 2022

MrKevinWeiss commented Feb 2, 2022

fjmolinas commented Feb 2, 2022

MrKevinWeiss commented Feb 2, 2022

gschorcht commented Feb 2, 2022

MrKevinWeiss commented Feb 2, 2022

MrKevinWeiss left a comment

MrKevinWeiss commented Feb 2, 2022

MrKevinWeiss commented Feb 3, 2022

fjmolinas commented Feb 4, 2022

MrKevinWeiss commented Feb 8, 2022

MrKevinWeiss commented Feb 8, 2022

MrKevinWeiss commented Feb 9, 2022

fjmolinas commented Feb 9, 2022

fjmolinas commented Feb 9, 2022

fjmolinas commented Feb 9, 2022

MrKevinWeiss commented Feb 9, 2022

fjmolinas commented Feb 9, 2022

fjmolinas commented Feb 10, 2022

MrKevinWeiss left a comment

MrKevinWeiss commented Feb 10, 2022

tests/external-boards: add esp compile test boards #17525

tests/external-boards: add esp compile test boards #17525

Conversation

fjmolinas commented Jan 17, 2022

Contribution description

Testing procedure

Issues/PRs references

fjmolinas commented Jan 17, 2022

gschorcht commented Jan 17, 2022

fjmolinas commented Jan 18, 2022

gschorcht commented Jan 18, 2022

MrKevinWeiss commented Feb 1, 2022

fjmolinas commented Feb 1, 2022

gschorcht commented Feb 1, 2022

gschorcht commented Feb 1, 2022

MrKevinWeiss commented Feb 2, 2022

fjmolinas commented Feb 2, 2022

MrKevinWeiss commented Feb 2, 2022

gschorcht commented Feb 2, 2022

MrKevinWeiss commented Feb 2, 2022

MrKevinWeiss left a comment

Choose a reason for hiding this comment

MrKevinWeiss commented Feb 2, 2022

MrKevinWeiss commented Feb 3, 2022

fjmolinas commented Feb 4, 2022

MrKevinWeiss commented Feb 8, 2022

MrKevinWeiss commented Feb 8, 2022

MrKevinWeiss commented Feb 9, 2022

fjmolinas commented Feb 9, 2022

fjmolinas commented Feb 9, 2022

fjmolinas commented Feb 9, 2022

MrKevinWeiss commented Feb 9, 2022

fjmolinas commented Feb 9, 2022

fjmolinas commented Feb 10, 2022

MrKevinWeiss left a comment

Choose a reason for hiding this comment

MrKevinWeiss commented Feb 10, 2022