Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nimble/scanner: migrate to errno return values #16839

Merged
merged 3 commits into from
Sep 17, 2021
Merged

nimble/scanner: migrate to errno return values #16839

merged 3 commits into from
Sep 17, 2021

Conversation

haukepetersen
Copy link
Contributor

Contribution description

Same as #16838: this PR migrates the return values to use errno values instead of custom ones.

As further optimization the nimble_scanner_status() function was changed to bool nimble_scanner_is_active(), as this feels more natural in terms of both wording as well as return value...

Testing procedure

Build test and code review should do the trick.

Issues/PRs references

none

@haukepetersen haukepetersen added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: BLE Area: Bluetooth Low Energy support labels Sep 10, 2021
@github-actions github-actions bot added Area: pkg Area: External package ports Area: sys Area: System labels Sep 10, 2021
This was referenced Sep 13, 2021
Merged
Merged
@haukepetersen
Copy link
Contributor Author

addressed comment

@benpicco
Copy link
Contributor

benpicco commented Sep 17, 2021 •
edited
Loading

please squash
(You'll need to rebase to fix CI)

@haukepetersen
Copy link
Contributor Author

rebased

@miri64 miri64 merged commit 7bf1fad into RIOT-OS:master Sep 17, 2021
@haukepetersen haukepetersen deleted the opt_nimble_scannererrno branch September 20, 2021 05:57
@benpicco benpicco added this to the Release 2021.10 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 left review comments

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: BLE Area: Bluetooth Low Energy support Area: pkg Area: External package ports Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2021.10
Development

Successfully merging this pull request may close these issues.
3 participants
@haukepetersen @benpicco @miri64