Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/esp32: remove the dependency of vendor code on BOARDDIR #14729

Merged
merged 1 commit into from
Aug 7, 2020
Merged

cpu/esp32: remove the dependency of vendor code on BOARDDIR #14729

merged 1 commit into from
Aug 7, 2020

Conversation

gschorcht
Copy link
Contributor

@gschorcht gschorcht commented Aug 7, 2020 •
edited
Loading

Contribution description

This PR removes the dependency of vendor code on BOARDDIR.

Testing procedure

Compilation of the vendor code wpa_supplicant shoudl succeed.

CFLAGS='-DESP_WIFI_EAP_USER=\"user\" -DESP_WIFI_EAP_PASS=\"password\"' USEMODULE=esp_wifi_enterprise make BOARD=esp32-wroom-32 -C examples/gnrc_networking

Issues/PRs references

Caused problems in PR #14490

@gschorcht gschorcht added Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Aug 7, 2020
@gschorcht
Copy link
Contributor Author

gschorcht commented Aug 7, 2020 •
edited
Loading

I wished we had PR #12971 merged. These tests would cover ESP specific modules to be sure that all applications are still compilable.

@gschorcht gschorcht requested a review from benpicco August 7, 2020 14:16
@benpicco
Copy link
Contributor

benpicco commented Aug 7, 2020

I also compiled gnrc_border_router with UPLINK=wifi for esp32 and esp8266, this used esp_now and esp_wifi - so this should be good.

@benpicco benpicco merged commit a455d74 into RIOT-OS:master Aug 7, 2020
@gschorcht
Copy link
Contributor Author

@benpicco Thanks for reviewing and merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gschorcht @benpicco