[tracking] unnecessary use of floating point arithmetic #19614
Labels
Community: help wanted
The contributors require help from other members of the community
Type: bug
The issue reports a bug / The PR fixes a bug (including spelling errors)
Type: tracking
The issue tracks and organizes the sub-tasks of a larger effort
Comments
maribu
added
Type: bug
|
|
bors bot
added a commit
that referenced
this issue
May 24, 2023
19662: driver/lc709203f: remove unnecessary use of float r=maribu a=kfessel ### Contribution description removes a unnecessary use of float ### Testing procedure read and test if you got that hardware (I don't) ### Issues/PRs references #19614 Co-authored-by: Karl Fessel <[email protected]>
bors bot
added a commit
that referenced
this issue
May 24, 2023
19556: tools/mspdebug: fix `make debug` and `make debugserver` r=aabadie a=maribu ### Contribution description The semantics of `make debug` and `make debugserver` have changed in the years since the MSP430 integration. This brings the implementation back into line with the current semantics - `make debug` now starts both mspdebug and GDB, no need to run `make debugserver` prior to `make debug` anymore - `make debug` no longer flashes the target to not waste flash erase cycles - GDB mutliarch support is added - support for selecting a debug adapter by its serial is added 19662: driver/lc709203f: remove unnecessary use of float r=aabadie a=kfessel ### Contribution description removes a unnecessary use of float ### Testing procedure read and test if you got that hardware (I don't) ### Issues/PRs references #19614 Co-authored-by: Marian Buschsieweke <[email protected]> Co-authored-by: Karl Fessel <[email protected]>
This was referenced May 31, 2023
bors bot
added a commit
that referenced
this issue
Jun 5, 2023
19693: sys/color: extend unittest and fix module r=kfessel a=kfessel ### Contribution description this extends the unittest for sys_color testing more colors ### Testing procedure ``` RIOT_tree/tests/unittests$ make tests-color test ``` will fail since our `rgb2hsv` implementation is wrong (or is using an other colorspace than hsv2rgb (without documenting)) the new `hsv2rgb` test will succeed ### Issues/PRs references #19614 was the reason i had a look at this #1315 added the rgb2hsv and hsv2rgb function #9940 added the test for black special case https://www.vagrearg.org/content/hsvrgb << some optimization for that function (avoiding float) Co-authored-by: Karl Fessel <[email protected]>
bors bot
added a commit
that referenced
this issue
Jun 5, 2023
19378: sys: add common imath module mv isin() form test/driver_dac_dds r=kfessel a=benpicco 19693: sys/color: extend unittest and fix module r=kfessel a=kfessel ### Contribution description this extends the unittest for sys_color testing more colors ### Testing procedure ``` RIOT_tree/tests/unittests$ make tests-color test ``` will fail since our `rgb2hsv` implementation is wrong (or is using an other colorspace than hsv2rgb (without documenting)) the new `hsv2rgb` test will succeed ### Issues/PRs references #19614 was the reason i had a look at this #1315 added the rgb2hsv and hsv2rgb function #9940 added the test for black special case https://www.vagrearg.org/content/hsvrgb << some optimization for that function (avoiding float) Co-authored-by: Benjamin Valentin <[email protected]> Co-authored-by: Karl Fessel <[email protected]>
bors bot
added a commit
that referenced
this issue
Jun 5, 2023
19378: sys: add common imath module mv isin() form test/driver_dac_dds r=maribu a=benpicco 19693: sys/color: extend unittest and fix module r=kfessel a=kfessel ### Contribution description this extends the unittest for sys_color testing more colors ### Testing procedure ``` RIOT_tree/tests/unittests$ make tests-color test ``` will fail since our `rgb2hsv` implementation is wrong (or is using an other colorspace than hsv2rgb (without documenting)) the new `hsv2rgb` test will succeed ### Issues/PRs references #19614 was the reason i had a look at this #1315 added the rgb2hsv and hsv2rgb function #9940 added the test for black special case https://www.vagrearg.org/content/hsvrgb << some optimization for that function (avoiding float) Co-authored-by: Benjamin Valentin <[email protected]> Co-authored-by: Karl Fessel <[email protected]>
bors bot
added a commit
that referenced
this issue
Jun 5, 2023
19693: sys/color: extend unittest and fix module r=kfessel a=kfessel ### Contribution description this extends the unittest for sys_color testing more colors ### Testing procedure ``` RIOT_tree/tests/unittests$ make tests-color test ``` will fail since our `rgb2hsv` implementation is wrong (or is using an other colorspace than hsv2rgb (without documenting)) the new `hsv2rgb` test will succeed ### Issues/PRs references #19614 was the reason i had a look at this #1315 added the rgb2hsv and hsv2rgb function #9940 added the test for black special case https://www.vagrearg.org/content/hsvrgb << some optimization for that function (avoiding float) Co-authored-by: Karl Fessel <[email protected]>
bors bot
added a commit
that referenced
this issue
Jun 6, 2023
19693: sys/color: extend unittest and fix module r=maribu a=kfessel ### Contribution description this extends the unittest for sys_color testing more colors ### Testing procedure ``` RIOT_tree/tests/unittests$ make tests-color test ``` will fail since our `rgb2hsv` implementation is wrong (or is using an other colorspace than hsv2rgb (without documenting)) the new `hsv2rgb` test will succeed ### Issues/PRs references #19614 was the reason i had a look at this #1315 added the rgb2hsv and hsv2rgb function #9940 added the test for black special case https://www.vagrearg.org/content/hsvrgb << some optimization for that function (avoiding float) Co-authored-by: Karl Fessel <[email protected]>
maribu
changed the title
maribu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
There have been a number of issues (#17486 and #12045 are still open) on use of floating point arithmetic. This tries to bundle the effort in a single place
List of offenders: use float and or double
without the double / float keyword using \d.\d
The text was updated successfully, but these errors were encountered: