Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/bmx055: fix crazy use of FPU #19691

Merged
merged 1 commit into from
Jun 1, 2023
Merged

drivers/bmx055: fix crazy use of FPU #19691

merged 1 commit into from
Jun 1, 2023

Conversation

maribu
Copy link
Member

@maribu maribu commented May 31, 2023

Contribution description

As the title says...

Testing procedure

Code review should be sufficient

Issues/PRs references

None

@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 31, 2023
@maribu maribu mentioned this pull request May 31, 2023
Open
19 tasks
@benpicco benpicco added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label May 31, 2023
benpicco
benpicco reviewed May 31, 2023
View reviewed changes
drivers/bmx055/bmx055.c Outdated Show resolved Hide resolved
@benpicco
Copy link
Contributor

Please squash!

@maribu
Copy link
Member Author

maribu commented May 31, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented May 31, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@bors
Copy link
Contributor

bors bot commented May 31, 2023

GitHub status checks took too long to complete, so bors is giving up. You can adjust bors configuration to have it wait longer if you like.

@kaspar030
Copy link
Contributor

GitHub status checks took too long to complete, so bors is giving up. You can adjust bors configuration to have it wait longer if you like.

after 41min?

@maribu
Copy link
Member Author

maribu commented May 31, 2023

I forgot that the squash will result in a new quick CI round ... I'll kick bors again when all is green

@riot-ci
Copy link

riot-ci commented May 31, 2023

Murdock results

✔️ PASSED

6ddf761 drivers/bmx055: fix crazy use of FPU

Success Failures Total Runtime
6933 0 6933 13m:26s

Artifacts

@maribu
Copy link
Member Author

maribu commented May 31, 2023

bors merge

bors bot added a commit that referenced this pull request May 31, 2023
@bors @jia200x @maribu
Merge #18156 #19691 #19694
d572516 
18156: pkg/opendsme: add initial support for IEEE 802.15.4 DSME time-slotted MAC r=miri64 a=jia200x



19691: drivers/bmx055: fix crazy use of FPU r=maribu a=maribu

### Contribution description

As the title says...


19694: tests/drivers/epd_bw_spi_disp_dev: fix accidental use of FPU r=maribu a=maribu



Co-authored-by: Jose Alamos <[email protected]>
Co-authored-by: Marian Buschsieweke <[email protected]>
@bors
Copy link
Contributor

bors bot commented May 31, 2023

Build failed (retrying...):

@bors
Copy link
Contributor

bors bot commented Jun 1, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit e71054d into RIOT-OS:master Jun 1, 2023
@maribu maribu deleted the drivers/bmx055/crazy-pow branch July 3, 2023 13:22
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2023.07
Development

Successfully merging this pull request may close these issues.
4 participants
@maribu @benpicco @kaspar030 @riot-ci