Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap project #2

Merged
merged 1 commit into from
Sep 11, 2024
Merged

bootstrap project #2

merged 1 commit into from
Sep 11, 2024

Conversation

zoedberg
Copy link
Collaborator

@zoedberg zoedberg commented Jun 12, 2024

Re-opening another draft PR since #1 was merged before it was ready (I've force pushed master to revert it). Please @dr-orlovsky DON'T merge or review this until I mark it as ready.

Since last PR I've:

  • refactored the transfers test, now we have a much more complete test where several possible scenarios are tested using 2 wallets, 2 assets and a transfer type (that can be blinded or witness)
  • improved README
  • updated submodules to beta 6

I still need to:

  • do a general code refactor/cleanup
  • wait for upstream fixes and beta 8 to be released

Copy link

codecov bot commented Jun 13, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@zoedberg
Copy link
Collaborator Author

I've updated this PR. Now it includes all tests that were added in separate branches (to report single issues) and it's ready to be merged.

@dr-orlovsky please note:

@dr-orlovsky
Copy link
Member

Thank you very much!

the TODO in the accept_0conf test, I think the commented code shows a bug on how RGB shows allocations of a 0-confirmations transfer

Is it the same problem reported by Bitlight team? Anyway I think we need an issue for it

the tapret_wlt_receiving_opret test is failing (so I've temporarily ignored it), this was working after

Let's have a new issue

I've added a mainnet_wlt_receiving_test_asset test that shows that a mainnet wallet refuses a test asset, therefore the issue reported in telegram by memes_ceo should not be possible

Nice to know that, thank you!

Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 132b8ba

@dr-orlovsky dr-orlovsky merged commit c9dd184 into RGB-WG:master Sep 11, 2024
3 checks passed
@zoedberg
Copy link
Collaborator Author

Is it the same problem reported by Bitlight team? Anyway I think we need an issue for it

Not sure which problem you are referring to. Anyway here the issue RGB-WG/rgb-std#270

Let's have a new issue

Ok, here it is RGB-WG/rgb-std#271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants