Allow to pay from both tapret and opret inputs #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoedberg
approved these changes
Aug 13, 2024
|
Thank you. I was a bit worried since at this stage I am really opposing adding new logic. Btw, this also allows spending from tapret inputs from opret wallets - and should also work for NfTs with combined taprets/oprets. So yes, this is a completion of huge epic we had since last October. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an enhancement over #246 which allows to spend from both opret and tapret inputs at the same time.
I am not sure whether it is worth adding it since it adds a lot of code and logic complexity - or is it just better to stick with UX-based solution I have described in #246 (comment)