fix(firefox): remove setTimeout from onLocationChange

[emish89]

What is it?

• Bug

Description

I removed a setTimeout that was giving error on firefox after page change. There are more open issues for this.

Use cases and why

I expect that now firefox works

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
partytown	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 18, 2023 4:36pm

[mhevery]

This looks reasonable, I will try to dig into why setTimeout is there. In the meantime could we have a test https://github.com/BuilderIO/partytown/tree/main/tests/platform which shows that the issue has been fixed?

[emish89]

This looks reasonable, I will try to dig into why setTimeout is there. In the meantime could we have a test https://github.com/BuilderIO/partytown/tree/main/tests/platform which shows that the issue has been fixed?

can you help me create a proper test?

I tried adding "firefox" to playwright but almost all the tests are failing. So I'm not sure on how to proceed and I prefer waiting for some help.

The issue happens only in firefox, at first page change.

The open bugs are at least these:
#505
#486
#457
withastro/astro#8862

[gioboa]

HI @emish89
I added the firefox scripts and your change it's working fine.

[emish89]

great, so you think can be merged?

[gioboa]

there is not tests for onLocationChange method.
Can you add them pls?

[gioboa]

I investigated and "astro": "^4.0.6" solves this issue without change anything in PartyTown.
Can you check @emish89 pls?

[emish89]

I investigated and "astro": "^4.0.6" solves this issue without change anything in PartyTown. Can you check @emish89 pls?

@gioboa I was involved in the astro fix. If you see the code: https://github.com/withastro/astro/pull/9419/files

you can see that the history APIs has been replaced. With these changes, from your point of view, partytown library is still working as expected?

It was intended as a temporary fix until partytown solves the problems with firefox from what I've understood.

[mhevery]

LGTM, but there is a failure.

[gioboa]

@emish89 the failing test is a flaky one. Now we have a green line.